From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966213AbdAILx6 (ORCPT ); Mon, 9 Jan 2017 06:53:58 -0500 Received: from mail-by2nam01on0078.outbound.protection.outlook.com ([104.47.34.78]:3074 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966372AbdAILxg (ORCPT ); Mon, 9 Jan 2017 06:53:36 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Robert.Richter@cavium.com; Date: Mon, 9 Jan 2017 12:53:20 +0100 From: Robert Richter To: Ard Biesheuvel CC: Hanjun Guo , Russell King , Catalin Marinas , Will Deacon , David Daney , Mark Rutland , James Morse , Yisheng Xie , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH v3] arm64: mm: Fix NOMAP page initialization Message-ID: <20170109115320.GI4930@rric.localdomain> References: <20161216165437.21612-1-rrichter@cavium.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.229.90.12] X-ClientProxiedBy: VI1PR09CA0081.eurprd09.prod.outlook.com (10.174.49.153) To BL2PR07MB2338.namprd07.prod.outlook.com (10.167.101.16) X-MS-Office365-Filtering-Correlation-Id: 7c0b326f-eb3c-435d-a765-08d43886236d X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BL2PR07MB2338; X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2338;3:/UCt7bqNLYbxjWwznwozarhacRB9uELpxO6tiXhOU71291/QmQaAQRS9VbaYkXxq2nLsM7bq96EVBGipmXzDoirmUm8OZefkh2YGYdgA2r23Q8J3bYtYbwTg5zp5oGgfEq0YKEo3toHo80SX+r4zaw2CrI23jtimmubiAbaF8hpM5mV8gGBoce7feiFg6bzzjkQS3IEAq1JG8mCm0N22EWe4Ly2YeGoFhzwv74NbcFKU7hYGtUO0lAFsWzsjknEIgCLWjk2DBQeLDQOfMMIKYA==;25:hm2ahiypHXjqcxJHgh1kF4bgA3lJtTNr8s7KGrGyYf/JFqfM2+3nEOt/JBcVQXgEEMGroRe2ckYcXb/Nq+sDF83WRpptp0wbg72mb+fJyNqFQfL9ZVUZ9bepSACo6Aams7Lu0OI1aXW/RWBGj0uoydZRdUIcoukeNx7klGVR7BrNZooB8MtGbDJSHJhw6k05UGmmYZ62LTqsBV4hZKA/0nxqaZxskaSfibfrZKP4GJBQB7jASaVaTDzqavK8a4vPAE8i+B+yeWfyHbPsMCLL81iul/eIsLDNe89UHSJBlO2pfAA4N+jw9bx/KSdTMCzkVOgP3lJ+rCKMJrcfV7FdzPti1HnhyLjIEq1z6IjKNGBmRUoa/JMaND1SImrrqtDJa4p6pp0fT9tg2lQ3YslTtiwNPRw49oH7emfbIdrqC4qH3WQqNZqTrOn2R9eLKdBITEwrhiMLPLzlnbl9IxWAOg== X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2338;31:rx71zcocEN4c15MYuJHN2Q9LNNDcd/xHy3MnbC8wz5GjaCEOI+dLZ7UOoUa+R6oRsLuiu0P8fZwpOwi9/dKck+JiYnjEiAAsqM+FGzwKKQ9snI7qagz9dEFkhSgGopAyqNH3otui7ARGxWFzTvgBLd6njOvP+/U2HQ/MIB/1UB5E2Hmn7dUjq+XoWEf5msIcAuKaM3MnaC5WO8L+kLXWsHPhVCU3uXplAMABk2UKXkUXPQMdaohc/3vOhs+xejbg;20:zgxtwBUdAYeySY4gdChXGTUp9n3wqd/aAZ3Jl6PFxPtwRnHgnsdozysszypDeIPng951eJ5Sqggl7Ma6ldVvRHsuEPDHXnxugaRG0q896MD8hUZkbv7/noCQmNA25/udZWePsw76LwAXrwuAU+CRCd55zqExW1/+W2mZHatILhtVsHhYNrG2FeEQnpHgWDsla65eDnyHKuxSxrG702SkCZqXM0YIwAcTDd4f4xgpgx40JIWFp7K8nO4x0h9+Mymb+XuW2FAFeUMC2VqD32JGCo2W1o6qZ2UGpZ9R1Mk+urBfDnlFEZFmGBjfGFrPAT8F2XcBDJ3AF0gR+8Uhz98MslGsgFjNcXUO1q6qQ7ViK9X2hJHude7xXlW+BqjRwayKB2dVjB8x1sV3axlUx0qBesFFkLO+Ap5nc36vmF6sTAf5F0Zxhir0Ys5ihrY67stkCRdqhm/d5Kn49zrFXQLu87X04KsOZgenGU/BM3Cu75Dtsrj2bPDii8u+TbmP3bSq X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123555025)(20161123560025)(20161123558021)(20161123564025)(20161123562025)(6072148);SRVR:BL2PR07MB2338;BCL:0;PCL:0;RULEID:;SRVR:BL2PR07MB2338; X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2338;4:Td1oIo8zPtyeXVS0h9FZA7WdScf7E5j4Dk/UzO6be+39RDYzMjIycGxqpQe6M9eD1pKHyBZOy9gRyyxoeqoaUCJaeuRPEx9OHPoJT2T+XkQBgZPORy/vsx9CXB4svWV9PBu2ORpQ6kpgDD3A8yOE+zWKWyXNB1vDwVn7ehK0D8jo3SriKTKwAV54tJyWhJHpV/MhfxdNBTw8SYotM3RZYlXILtGRRGr+NT/n3ipTCmsZXKgODVHrMwmo8XvBjMN7dLFW5xvzm6KLpRfjh/It2FU9S77pEcQ+5gwylH9MyVAK9SK0VgechJZzZWbYUqhkkeiSLwzeabMoV17EscisbDezM8uLCJimV09g2EJQIgjgSlZvXPM/SkgFkeWXzPpg0TBfjfF7d/nUaw0XI9qyE8Ow4fjhK6ciflRtwBdijF1mvbGa9tWkWMwI6+UW4VFBKhVDYuDV6j3L3kp1d2IvqVY2whHsCllZ3i6p2AzmYpMfa5T/gl5IexOa2JPN6zV/+Q58gwmIAoppIFZZF1CxdWbdx0C1ovH7jaOu/yMLgKjeMsWx+Gv1+qv/4RxC/HQ02LQtKbnEnCB6UYoEvlGq4D4xSI+l59NknFIwWEicpDg= X-Forefront-PRVS: 0182DBBB05 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(189002)(199003)(24454002)(101416001)(25786008)(4001350100001)(55016002)(9686003)(97736004)(6666003)(110136003)(6916009)(4326007)(2950100002)(42186005)(92566002)(5660300001)(8676002)(50466002)(7736002)(83506001)(86362001)(23726003)(68736007)(81166006)(305945005)(81156014)(93886004)(6506006)(50986999)(97756001)(1076002)(189998001)(76176999)(54356999)(38730400001)(66066001)(7416002)(46406003)(3846002)(229853002)(54906002)(47776003)(6116002)(2906002)(33656002)(106356001)(105586002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2PR07MB2338;H:rric.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR07MB2338;23:EHobRIbmDk62ltIs3xMVtpuFiX3jd3zV6fc8LpJhO?= =?us-ascii?Q?ZfOE0qAA+P3GQ+nEEoJViPHXdvk9gv37DWfoa0yJCYjpp/WcmncKyzMh+xiV?= =?us-ascii?Q?u/4mAOLTn+fS6dxn7JDHnoX7NUeQZEGeGrBPbgJyIVHsuCAul//uvm1Aqu2b?= =?us-ascii?Q?kdGM9QykchwCbNb4lI8biw+W3Vij0wfl8uhYVeVGNd4ETOOgZAdeMr4wBRzV?= =?us-ascii?Q?VvJR2400n970gFeaAGAnsy1W0PS0qPfQYBbnhMNWQnR2OnU0YCeDRW++3HF6?= =?us-ascii?Q?4HrF0PW0/AL1LItu6daCHZdxKH31xFhi5mZKt5JPI2X4XBWe8Gnl1o/SS3wU?= =?us-ascii?Q?CLfMVaN2VZ1+TC6ddiJqKuqGKuERf5KS/JO9dPxoEb33ahv07ulAS2UgKMqu?= =?us-ascii?Q?PwTTcsv8qSvXosOepxqSAccIlUG0EAsgTxvGkl3qOcPu8PCiwf7DXWIx2nRe?= =?us-ascii?Q?JXAwNqmFwTulJc3ag1pIFU4s+Dtzg1l4O2dhP7j+Iua9caqBIYmY6B9rsgea?= =?us-ascii?Q?+9LbamTbakvXbP7V8oM/FgDScK4U10gwE6TsV1+hUYvwP9t+Kbc4F6gQTguH?= =?us-ascii?Q?qcR6fDu2alMPxuOhckGqq6PBE+eBcj7CXntDPQ08okmpY3kosRZBmj5JO2X9?= =?us-ascii?Q?JyLPPISByHV0SmlOTVSDtKPUgsT7egPpuZJ0bzaqYkq1eZkWIuWVnlmTi8e7?= =?us-ascii?Q?WHCFAs0S/lAlg+cE1kp4vP+62xGbqhYEyA1aYbf/LFRM8jAi5XJWlPoo7cg/?= =?us-ascii?Q?QxX8i0g1U0X4qb7YinEfegnKuYOhiPF2peOCLzkOv3v7UuBZfrDiNW2eGckl?= =?us-ascii?Q?3xtBR44BDczu46cH8BgAbyfTjytuW/aqDT5+PFYeD5q38p1Nmmv89eQjl2pL?= =?us-ascii?Q?AF8OBc94sm+EVP6Kl1NkeTHWdUt3z08PJfeiw9sM4FfpLe1LV8hklFL5oODC?= =?us-ascii?Q?5LjzqfeOcldu9j4woseanmPlDEdEQedkd8BxlTjDyVbchMEpYjz6Uu9V4Cx+?= =?us-ascii?Q?Mt3DwliWgPpnpXgBxPLXTlqEqLY0IHObZs1pEVSEyH6RvC3U/5WSGST3/BOg?= =?us-ascii?Q?cuI4IVQ0vRBcHV475rWPA7MyoLEOAi0xUH/kfwKT7Tpe5bnei40w4IOZ0Ve4?= =?us-ascii?Q?l9L8TxXV/9FImUpZEbjiljNmDD8ogAfT1VG7WIf5p82vRx7ARyruCXp+nsWf?= =?us-ascii?Q?U3k34JWJNYE/QXRt3zdYcNtuCtDOMTAK3B/HrPqPeLZfBCB90hZwJrV2+VMJ?= =?us-ascii?Q?UHpxv5J6Vf49luTwOMTV8XV7PyNY7II5Dwb/MlD?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2338;6:HOYUB6kqZYeqPVPvXkoZyZfHvP5MGq/NWVX+9MkZJYXIh6f1Swa450gx3KL4c1uRWOJVSfj1dNts1DM+M7bVrRpvevhfnKd6ZIID0fqxfzg1DaT5k/UZy41+jeXKWBSezKJDeye7asaRZDeNKuaZtHB4qKItltNfpkEyRA/NOD6wOrteISJH3iPm/XD0k7UZR0RMhtzLSvsk10Mlz0sV9feSE4HUPeyqQc6bQy9MxVdEf0r1t4ZkPZ21tz/8ECP+hy7420cd9Mn3uIYqlasoAGzStNzgYAMi7tHoy27/fyE94mmipssfKpjX7cxGB5ZGU+3Io7+dX3YxgwF8lHR61P97aOh/ZBL45Z9vv0HiArqKk/55dOQCtVmYqJ1RfnjoGeSeyotqmDAR0qm89x1iDKVHgH9oNqFU4nygMRj+ga0=;5:lVrP5V7fBBAdqbDqaQ7tEDFJVrOKUo1RptpruDvOfZ4LezhpKiBlsyGFIrv5Rol8tF4vt53Y+LXZTyVwDexnFTs4cfrZNSHCNiEUJ8FdhEIwVAif40YvDHxccYQGeJKJht4CjTyD/bg1VI30hNbFBfyfzqZmplFkjXQ3M5e3LEg=;24:AAU76wzIPLMrHQef0zCtvBFofXZt/vL8UDfsNXiUhW6c4zqC21mCP+4pz5CRZ1UhNe1rW1hT8vfVmPUBzN1QKozWvF3M7Z3+hN5x3WHxhjI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2338;7:ZDOqjaNs/nSeP6ntSoR+TML+8hv3M6T7gZilavXI+31AOjoxOTxBmqROpZj9N6zoPzYOjumKfBM9X1P+0ZxDI+1F0rIPmouU+kYzwQWj1+ybZ7OVtZRHFC2GT0hNvejM92J4YlQ8FogXX2sJ2xuBcxQyVwhTJE4beZEHKPSXGKqv9RKGxK1TG8FJKXh5e2xriW95VjdECLs6CBAyOn7mM86aXR7rOh5aaamn1kAFc5FypyNSrYx6+Js52z5u6Su2wEKzsYGuv9q93e2wG7/yuIaulNItgd2v8Lp7P6yzLQfxRroF4crPpRP7j3FV21xLsVMIa85gcCW1APeL2Lu7TiQkkJVQASiTIF+xTh+cJjKrEvcl1fi4f4Z/RpMI/dAbNUYdQshuYuBBMPc6+3ujBS2S5Ise5x6ZLPzzL8Eds5wa/a+xPkuet+/9WDDmcfyUsudSPsSSwX7HhOn6siLVHg== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2017 11:53:31.6708 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR07MB2338 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06.01.17 08:37:25, Ard Biesheuvel wrote: > Any comments on the performance impact (including boot time) ? I did a kernel compile test and kernel mode time increases by about 2.2%. Though this is already significant, we need a more suitable mem benchmark here for further testing. For boot time I dont see significant changes. -Robert Boot times: pfn_valid_within(): [ 25.929134] [ 25.548830] [ 25.503225] early_pfn_valid() v3: [ 25.773814] [ 25.548428] [ 25.765290] Kernel compile times (3 runs each): pfn_valid_within(): real 6m4.088s user 372m57.607s sys 16m55.158s real 6m1.532s user 372m48.453s sys 16m50.370s real 6m4.061s user 373m18.753s sys 16m57.027s early_pfn_valid() v3: real 6m3.261s user 373m15.816s sys 16m30.019s real 6m2.980s user 373m9.019s sys 16m32.992s real 6m2.574s user 372m45.146s sys 16m33.218s