From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939840AbdAINvD (ORCPT ); Mon, 9 Jan 2017 08:51:03 -0500 Received: from mx2.suse.de ([195.135.220.15]:49347 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758728AbdAINux (ORCPT ); Mon, 9 Jan 2017 08:50:53 -0500 Date: Mon, 9 Jan 2017 14:49:59 +0100 From: Petr Mladek To: Sergey Senozhatsky Cc: Andrew Morton , Steven Rostedt , Peter Hurley , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 1/2] printk: drop call_console_drivers() unused param Message-ID: <20170109134958.GD20785@pathway.suse.cz> References: <20161224140902.1962-1-sergey.senozhatsky@gmail.com> <20161224140902.1962-2-sergey.senozhatsky@gmail.com> <20170103102230.GK14894@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170103102230.GK14894@pathway.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2017-01-03 11:22:30, Petr Mladek wrote: > On Sat 2016-12-24 23:09:01, Sergey Senozhatsky wrote: > > We do suppress_message_printing() check before we call > > call_console_drivers() now, so `level' param is not needed > > anymore. > > > > Signed-off-by: Sergey Senozhatsky > > --- > > kernel/printk/printk.c | 12 ++++-------- > > 1 file changed, 4 insertions(+), 8 deletions(-) > > > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > > index e2cdd87e7a63..11a9842a2f47 100644 > > --- a/kernel/printk/printk.c > > +++ b/kernel/printk/printk.c > > @@ -1510,8 +1510,7 @@ SYSCALL_DEFINE3(syslog, int, type, char __user *, buf, int, len) > > * log_buf[start] to log_buf[end - 1]. > > * The console_lock must be held. > > */ > > -static void call_console_drivers(int level, > > - const char *ext_text, size_t ext_len, > > +static void call_console_drivers(const char *ext_text, size_t ext_len, > > const char *text, size_t len) > > Yup, this patch makes sense on its own. The level parameter is unused > since the commit cf7754441c563230ed7 ("printk: introduce > suppress_message_printing()"). > > Reviewed-by: Petr Mladek The patch makes sense on its own. I have pushed it into the for-4.11 branch, see https://git.kernel.org/cgit/linux/kernel/git/pmladek/printk.git/commit/?h=for-4.11&id=0e91b77060387275b6762c6688e3bddd1b808e2c Best Regards, Petr