From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762260AbdAIPFl (ORCPT ); Mon, 9 Jan 2017 10:05:41 -0500 Received: from mail-co1nam03on0077.outbound.protection.outlook.com ([104.47.40.77]:58144 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751008AbdAIPFd (ORCPT ); Mon, 9 Jan 2017 10:05:33 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jan.Glauber@cavium.com; Date: Mon, 9 Jan 2017 16:05:17 +0100 From: Jan Glauber To: Rob Herring CC: Ulf Hansson , , , David Daney , "Steven J . Hill" , Mark Rutland , Subject: Re: [PATCH v10 8/8] dt-bindings: mmc: Add Cavium SOCs MMC bindings Message-ID: <20170109150517.GA2862@hardcore> References: <20161219121552.18316-1-jglauber@cavium.com> <20161219121552.18316-9-jglauber@cavium.com> <20161222203242.nxnmqyldtvdxkqhc@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161222203242.nxnmqyldtvdxkqhc@rob-hp-laptop> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [46.5.207.65] X-ClientProxiedBy: VI1P193CA0021.EURP193.PROD.OUTLOOK.COM (10.175.177.159) To SN2PR07MB2592.namprd07.prod.outlook.com (10.167.15.22) X-MS-Office365-Filtering-Correlation-Id: ee3ac8ec-1f3f-49b0-5196-08d438a0f4d5 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:SN2PR07MB2592; X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2592;3:ehdUqMjrvLoxT1W5o24/u5t1DNPIEme0oUG7qbE+YdCkK0R6jo0TFDeOBeEanXzXZfcV/2E7MJjep50HPnAmb+qFjayqSGKWnuiVaj8DyEXYhv0SPAR+0uU12qHqjrfksQp2VgzMR1LbKZ810D/n0BiLPPYUiVsZrHjpMq86a+2zbLgIH2epfZCd3eUNd1ADpVGoZWT52S6z5TzE42GEk22FM/1xTffhND/n2SBm3CEP454srDxXftO9HbMs2Wr0710F0ho7C5rawSyDEL4f/w==;25:u5gmTnlox+DPIcLAZ0gBjGZGjYQz88fkGgOT1rOYvdXlfOanif+ZwDZDpX+heG9hJNba8VKbKBQTzrexNqOUuDA56qLwrLN2wUiB0q7WQEaIuMZ/3lc1XoIzLcPOdFBwVAxWof1M3QwTd3GGnishYnQQ3Swe8EV1dpJ5fnv/mnRr/dRA1eEIgRko97aVeteF9AeBuCp0mtYElFj2EvvuC70ikuVY/Lww6s2eKxKRqFKILuoztXN6Lh7sok142q5F5iAvitv0bnOhvanatnRqdVGyeuGm+E1PribUQV9NrkFZpS8iBySmOoGJ3OoVf8Qi0T4/aZoupsykfv33zmCG1Z1tvP6A73kYOCQrPMijjSyHRpU/rOjQTxau2C+AHiDn+khMSYKsfCGCUkCboII0v5n0j8hI8wwAeClzGoE9MPi/QFfm1N+T771Q3VhkPg1T X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2592;31:9gMi7q9w8Fhl9A0BxLUas7MDqw6KObyMPDAO5irj3pqsUwWfZ9Nkh48GF8LdLkJwex54xbY66o+cCMhk5LFD9vC2CMgjnshZcyk4Z/hzUZMBrGK/NkajQ98RzqUvwg84jNlGJS9ZDLD2UCbHo89fXne4pBA/NDPblbWowykO0lA8q4gkuVs/yOihTxiCcgNOcLvVr3BUmsKDn7Nl7Oi01cHWsacULGt89X04OF752RKWb7L0hnGy5+sO4gHLTBbL;20:byFdUM8BFBQXfJyg2hu9OLdpVBY1GAKtzD9h2xCGBB14lcEtXMQKNqr2mrBptqdZTDqLsDqyucwxxcJhR0Z37a0YaO+o+nUo9MII5izhFdJbA3QPp/mQSPkzIywrhriMx9l0qWPBXWCbMekllyqpHxbJaB39FrZr/vOyRIwKE66Zh2iDQ+mkih7BR0fdMtwGmiqUNr4cJrwL2XBChi5ZQ4wXh1QQXErekMJ78Yg21lNz81UlsiwRkMjPXyyyFVXWAO+6Zpa4T7npzjOVmOo58IrxID2QyAsMICbi4FNZXd5900VQc3y3Ly4bnvQflXTXg+N7BV9pHumeL/0B5x/WAHh85iNsJwBCscpWftNt/oQ6PhGpLIDFtUdqB+pR9gmxmhxe+LGFWSj07ujC/5Q3fVApFc1iYP5WpaM6uIyJ1yTAmSGHqHDyalvGoidGOVaiiwkGyfsVUWT8pq6Sj1MmiphuZqnkP192KR+Wp+F/agdjQWI7H4mPebJLS+MnTzrNs8cDHV0kERBmEM4Eyw8DyA5Bb2ZzMUeD0Orx+FYvges7P8xZAPuMsSwmkEghhOjFo4286gfHOaE+B+UEd0nW27x2Q1/eeBdPLAucQH4iKQ0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148);SRVR:SN2PR07MB2592;BCL:0;PCL:0;RULEID:;SRVR:SN2PR07MB2592; X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2592;4:RIMfv00lgS4C8Ad0RInWLRQ4hUsOeoBYglenNwepH5qv5DOvioI+2bz1OV3EKtqwyg6AhUGzk048N8uV3CCyECiMPzKvDAIx1NPVZKCUZv9YNN/YZm4lL0dwNkG39Dkb8MayMjejbbzEq9s+j4nqCE5+JGZu1tLwq0vmFWWlthUdiYp4Sp+BfVDbDOfHNCeo2+kpbTHc5q8sShFIYpNXCoe/0rzbfUiCTjE3XsGlPHltEaWOrh0vgFUvPOuYT207gSr5LrLDZos7hUV3v6muyRaAvi9bbexHWgBdF5X9GldD+b+/yXi9SlENtjnbQX5jxKCoVE3zHb5b4hHVnnpbGzWUBgm9okEqFGHxFGP0T7BBs0SNMWbgQHMD1/jskNXzuVsJMJf6Iq2h6hnCDjYqd+rOB39bUkGbZw0OaUADPmBlA238rs5WdfVuZk8FXOr9ZxgMOzJ7hEstRaoBejOyXBw+CBzoQWzbWUQXFIOBm/hPGnCe+cSczB+GGYhonPThZsWAcrjS1YNke9RHhasMGt9/oQ5thlInpWP3reIgZ+n9Wj9NCiLRiqWB6wxiHjNEGTz0dMGlNp7660dPdKG6Y5Mfw6amiO9kVBIuoPmvsUiRiPaLjwIMla9xEsw6M9WBaT67QKuxCVjGFAYuWSUG+Q== X-Forefront-PRVS: 0182DBBB05 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(199003)(24454002)(189002)(83506001)(55016002)(50466002)(33716001)(4001350100001)(189998001)(97736004)(46406003)(33656002)(68736007)(5660300001)(575784001)(1076002)(4326007)(110136003)(42186005)(38730400001)(47776003)(23726003)(3846002)(105586002)(2906002)(6116002)(106356001)(54356999)(76176999)(42882006)(81166006)(25786008)(6496003)(50986999)(66066001)(6916009)(54906002)(6666003)(7736002)(97756001)(305945005)(229853002)(92566002)(101416001)(9686003)(8676002)(81156014)(2950100002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN2PR07MB2592;H:hardcore;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR07MB2592;23:hfHfw+nSlr9ga2O564GvKUX8XUaDtHevnQbsf12kH?= =?us-ascii?Q?O1mh5coSpeHy1mPYnjhpsb3SaXobFvjEZaZGnnCezMwlpJTHxgBc4QIflGl2?= =?us-ascii?Q?GQAH2+LlDCvbjxp5LAkQYUWYJ4nUijfrCicpeAsTDykFJUN7FODJGvjSvo19?= =?us-ascii?Q?Fp0anpkHcLUpuCDKtAEh7u1RSo8Zx864HsjqnPwJBDTZjNHA09gNj0xeAZfk?= =?us-ascii?Q?Y99MjBa/2+/H7cu5vr8T/FZWh4xEjhUxZptTTl4qzOma3Cz353m42bhLDEyM?= =?us-ascii?Q?7FWgZEmIsNNHSg+7FiAF/HCv6bej0k0QmFpeVLSdRWl3V++nJYiHXCyy3xmw?= =?us-ascii?Q?hUJ8zVwGU2Gl+4J+SsYn2lMwn81clUBXnu8Sy+r6Zn3kBbRh3/muNUZGuMEl?= =?us-ascii?Q?0sgGwklNGQafSgI7Le/ULPeCwr07dGxKVhq/eJmhtX3k0RSFe42uyju4vgXV?= =?us-ascii?Q?YSKkJ+6zQiC0YRPlxZhLQffKu0cctF7m+Jg88KPzUeUKQoTKYCKFWCAmWnoq?= =?us-ascii?Q?oSntmG0P6+P9Bl7JPZIqMxzGi5aH1Iat8tVdMytvevBZtenoq2IbUX67vtUE?= =?us-ascii?Q?vsTn9o4/RWpEkREPkCPj3kAaSRyGaWbEQGjiMdokSoKaYs6ByqNL+aWq0P32?= =?us-ascii?Q?HAPZWOjQxgDBLx8qs8o808WNnSmvIcjVkS6LTmblNwSGusSCSwhgWVy//fHs?= =?us-ascii?Q?oobVCrn4wMi8zYVm9uyEUdIFwbOJ+rZkj5x58if5RPAVgZzGGXiyWTNvjK9T?= =?us-ascii?Q?JDLZ0CtTDyU5b22HIcv5neLLeZP5Eng9yTEFch3CZ+n9bEoGqWj0DcE8bBHp?= =?us-ascii?Q?rl49CPRM/52T0WYUvMWHBmg9ZIj4aqhmEXCk9mI2AXrtjaAhULcXU96FMftW?= =?us-ascii?Q?VgcWlgFyjAYU9+nGRGBE3MdMk/PR768xgF6uHDkzSX/jVeKQl8HRR36sVYKo?= =?us-ascii?Q?SIMTZ1qFmIKkAK1URAMfN6zWe2GbS/NFBGTWNfjc5nJb7uzAAIWT4+uPPvK8?= =?us-ascii?Q?XkvTxwAjei+SBVnJnEJXiDQ1FRMPZaH4Rc1w1fsuqyuwAnAn8BqcFgZyFhbU?= =?us-ascii?Q?pf2/Pw7rvd+QgBCoNE3XU2AVAeCQ8K3JDjpqNXLvnk6RdKsEGKeNNoZOwfHS?= =?us-ascii?Q?8TbdgSfNIkdWBRbYo4L76n7dfmeSerVKVGDQDnrBioTY6P4SMPYByGEwoz2m?= =?us-ascii?Q?wsB5/0RK2yVHfcaR2756KpGr0/+m4CQrdNGVD3CWRIl8LZ9MMK6hAYtcXmGg?= =?us-ascii?Q?wqP9B9zb6zodmo8/w0/niLQVUrxy82a1A/aTwEQ?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2592;6:9XU8Rp+xMEXXuXzkmXFXPYXPzcCFhRxJ5URX7HR0r7+2m6kDfsAdcLZjFOI5oEDERjGwrOOQCbXte0QZcMFdDR+8Jzgj5PMfuUlIj0D6LPHmappk7ywe9KY6pEDGnUU8z2/os0sVfuyxiM3F9wbrf+57BWqFOOZHZstoMwigoF57uifclwkJfwGptkuSycYL7uek+c0k/2m8a4oqzYnNlxYwxrmX1XGybuyrvsQ9QsWTm04APf3rvmC4+RfqlTpaSpQW4wkbD72fszB77jpEygvjgjuGcSn6zGJeWnNZyqGL3qnbCeGuH1FXmK3ss/IqlAcGZvK3L2Cz/XQiEo4VRXxdgH1s5KP3LP1trcC1Jo/J0w7evOH53wCf/g6ufT6KJCYbQAfYt7vfcdI/CToQL47XipYsZ0hl2CJCKyFQrMU=;5:zbGhRaFy8hOZKHXO639FCq3kIN0IBg3PA1KdtK5lZ1WvQjVcCZVm1ZziErRdBJ/iTDLfHOIiuu/RdszlcFyvrr8gRxxWyoCGE2gzWYU1BXC0W6Y5U++PnbUNg4jYOByXylr7EMzlbHVztjukBeQZBNPXOpC/d1bEWeoGqYr+KOk=;24:46njnw79AeAH4rROFTpSeCYCk+4XqYUYjaXqsG7WS7/KsoSGLB8AQcH4o1hvmk1oZ0xK4VYo+wH6u4u5o1kCtZas6gWFbqlJwIlHqRGkiB8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2592;7:rRlPUByWnfJNv7hd8gpKKT4xGotVseUg5+hIqpUJAvkeWBndjl+lsYgICg9QbqWog9FyMPxfhefj0ojdMYDeI4Yxyz4v9yt65UrW4cV9vHGgKJIt7kTjEslrrAjq7m3PkjT81fq98XHXZCurKfdjfYhgO+SjgGgenAxTa8o/SHeTD10J7WK1mFWQama65ytgkmf5+lY0wbBL5dY1E2686ncu68r1MFgtDzBSwDNxxWNBpFU0ZhyWSw3sgZ7QGFX7If3i2G2FHZJmUWUBsCPQ+zFHGMgjZxPT/dHKwc6AfFQGA83zGHpfJcvMuQ4SxFftrJ/8tFwHslN2mjf5efK3JVBnCUhfwqQDAviT652Y3UJDXkrn8iO3OE2fcY0hoRvZbzSuYiExqfJh5+alfFu47llKBUA2VzI/tlN6DiONf1Jl3PRXxlQu4M4229hhxHTO8owdqDmc8zxOK2OG5Q5OsQ== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2017 15:05:30.3762 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2592 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 22, 2016 at 02:32:42PM -0600, Rob Herring wrote: > On Mon, Dec 19, 2016 at 01:15:52PM +0100, Jan Glauber wrote: > > Add description of Cavium Octeon and ThunderX SOC device tree bindings. > > > > CC: Ulf Hansson > > CC: Rob Herring > > CC: Mark Rutland > > CC: devicetree@vger.kernel.org > > > > Signed-off-by: Jan Glauber > > --- > > .../devicetree/bindings/mmc/octeon-mmc.txt | 59 ++++++++++++++++++++++ > > Perhaps cavium-mmc.txt would be more appropriate now. Yes, forgot to rename it. > > 1 file changed, 59 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mmc/octeon-mmc.txt > > > > diff --git a/Documentation/devicetree/bindings/mmc/octeon-mmc.txt b/Documentation/devicetree/bindings/mmc/octeon-mmc.txt > > new file mode 100644 > > index 0000000..aad02eb > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mmc/octeon-mmc.txt > > @@ -0,0 +1,59 @@ > > +* Cavium Octeon & ThunderX MMC controller > > + > > +The highspeed MMC host controller on Caviums SoCs provides an interface > > +for MMC and SD types of memory cards. > > + > > +Supported maximum speeds are the ones of the eMMC standard 4.41 as well > > +as the speed of SD standard 4.0. Only 3.3 Volt is supported. > > + > > +Required properties: > > + - compatible : should be one of: > > + * "cavium,octeon-6130-mmc" > > + * "cavium,octeon-6130-mmc-slot" > > + * "cavium,octeon-7890-mmc" > > + * "cavium,octeon-7890-mmc-slot" > > + * "cavium,thunder-8190-mmc" > > + * "cavium,thunder-8190-mmc-slot" > > + * "cavium,thunder-8390-mmc" > > + * "cavium,thunder-8390-mmc-slot" > > + - reg : mmc controller base registers > > Following PCI addressing? Yes for the host controller, for the child nodes we use reg as the physical slot number. Maybe I should describe the child node properties separately? > > + - clocks : phandle > > + > > +Optional properties: > > + - for cd, bus-width and additional generic mmc parameters > > + please refer to mmc.txt within this directory > > + - "cavium,cmd-clk-skew" : number of coprocessor clocks before sampling command > > + - "cavium,dat-clk-skew" : number of coprocessor clocks before sampling data > > + > > +Deprecated properties: > > +- spi-max-frequency : use max-frequency instead > > +- "cavium,bus-max-width" : use bus-width instead > > Drop the quotes. OK, droped them also above. > > + > > +Examples: > > + - Within .dtsi: > > Don't show the division between files in the example. OK. > > + mmc_1_4: mmc@1,4 { > > + compatible = "cavium,thunder-8390-mmc"; > > + reg = <0x0c00 0 0 0 0>; /* DEVFN = 0x0c (1:4) */ > > + #address-cells = <1>; > > + #size-cells = <0>; > > + clocks = <&sclk>; > > + }; > > + > > + - Within dts: > > + mmc-slot@0 { > > Need to show this is a child node. OK. > > + compatible = "cavium,thunder-8390-mmc-slot"; > > + reg = <0>; > > + voltage-ranges = <3300 3300>; > > + max-frequency = <42000000>; > > + bus-width = <4>; > > + cap-sd-highspeed; > > + }; > > + mmc-slot@1 { > > + compatible = "cavium,thunder-8390-mmc-slot"; > > + reg = <1>; > > + voltage-ranges = <3300 3300>; > > + max-frequency = <42000000>; > > + bus-width = <8>; > > + cap-mmc-highspeed; > > + non-removable; > > + }; > > -- > > 2.9.0.rc0.21.g7777322 > >