Re: [PATCH 1/2] sched: Introduce rcuwait machinery

Davidlohr Bueso
2017-01-16T01:32:44Z

On Thu, 22 Dec 2016, Bueso wrote:

>+ WARN_ON(current->exit_state); \

While not related to this patch, but per 3245d6acab9 (exit: fix race
between wait_consider_task() and wait_task_zombie()), should we not
*_ONCE() all things ->exit_state? I'm not really refering to a specific
bug (much less here, where that race would not matter obviously), but
if nothing else, for documentation -- and I doubt it would make any
difference performance wise.

Thanks,
Davidlohr