From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161464AbdAJBCh (ORCPT ); Mon, 9 Jan 2017 20:02:37 -0500 Received: from mga06.intel.com ([134.134.136.31]:29595 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934377AbdAJBCc (ORCPT ); Mon, 9 Jan 2017 20:02:32 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,341,1477983600"; d="scan'208";a="28288073" From: Andi Kleen To: acme@kernel.org Cc: jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: [PATCH 2/5] perf, tools: Add one liner warning for disabled features Date: Mon, 9 Jan 2017 17:02:22 -0800 Message-Id: <20170110010225.24870-3-andi@firstfloor.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170110010225.24870-1-andi@firstfloor.org> References: <20170110010225.24870-1-andi@firstfloor.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andi Kleen Add a one liner warning for perf features that need to be enabled explicitly by the user, so that they know they are missing something. Currently enabled for XED and BABELTRACE. Signed-off-by: Andi Kleen --- tools/perf/Makefile.config | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index 05dfa31506b6..e313739238a8 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf/Makefile.config @@ -65,6 +65,8 @@ ifneq ($(ARCH),$(filter $(ARCH),x86 arm)) NO_LIBDW_DWARF_UNWIND := 1 endif +DISABLED_FEATURES = + ifeq ($(LIBUNWIND_LIBS),) NO_LIBUNWIND := 1 endif @@ -696,6 +698,8 @@ ifdef XED EXTLIBS += -lxed $(call detected,CONFIG_XED) endif +else + DISABLED_FEATURES += XED endif ifndef NO_LZMA @@ -770,6 +774,8 @@ ifdef LIBBABELTRACE else msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev); endif +else + DISABLED_FEATURES += LIBBABELTRACE endif ifndef NO_AUXTRACE @@ -841,6 +847,10 @@ ifdef LIBCLANGLLVM endif endif +ifneq ($(DISABLED_FEATURES),) + $(warning Disabled features, need explicit enabling by user: $(DISABLED_FEATURES)) +endif + # Among the variables below, these: # perfexecdir # template_dir -- 2.9.3