From: Vinod Koul <vinod.koul@intel.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: dan.j.williams@intel.com, tony@atomide.com,
linux@armlinux.org.uk, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
arnd@arndb.de
Subject: Re: [PATCH] dmaengine: omap-dma: Fix the port_window support
Date: Tue, 10 Jan 2017 11:08:45 +0530 [thread overview]
Message-ID: <20170110053845.GX3573@localhost> (raw)
In-Reply-To: <20170109145052.26837-1-peter.ujfalusi@ti.com>
On Mon, Jan 09, 2017 at 04:50:52PM +0200, Peter Ujfalusi wrote:
> We do not yet have users of port_window. The following errors were found
> when converting the tusb6010_omap.c musb driver:
>
> - The peripheral side must have SRC_/DST_PACKED disabled
> - when configuring the burst for the peripheral side the memory side
> configuration were overwritten: d->csdp = ... -> d->csdp |= ...
> - The EI and FI were configured for the wrong sides of the transfers.
>
> With these changes and the converted tus6010_omap.c I was able to verify
> that things are working as they expected to work.
Applied now to fixes
--
~Vinod
prev parent reply other threads:[~2017-01-10 5:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 14:50 [PATCH] dmaengine: omap-dma: Fix the port_window support Peter Ujfalusi
2017-01-10 5:38 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110053845.GX3573@localhost \
--to=vinod.koul@intel.com \
--cc=arnd@arndb.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).