From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
zhaohongjiang@huawei.com, miaoxie@huawei.com,
Gu Zheng <guzheng1@huawei.com>
Subject: Re: [PATCH] tmpfs: clear S_ISGID when setting posix ACLs
Date: Tue, 10 Jan 2017 08:12:07 +0000 [thread overview]
Message-ID: <20170110081207.GO1555@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20170110080301.GA32191@quack2.suse.cz>
On Tue, Jan 10, 2017 at 09:03:01AM +0100, Jan Kara wrote:
> On Mon 09-01-17 09:34:48, Gu Zheng wrote:
> > This change was missed the tmpfs modification in In CVE-2016-7097
> > commit 073931017b49 ("posix_acl: Clear SGID bit when setting
> > file permissions")
> > It can test by xfstest generic/375, which failed to clear
> > setgid bit in the following test case on tmpfs:
> >
> > touch $testfile
> > chown 100:100 $testfile
> > chmod 2755 $testfile
> > _runas -u 100 -g 101 -- setfacl -m u::rwx,g::rwx,o::rwx $testfile
> >
> > Signed-off-by: Gu Zheng <guzheng1@huawei.com>
>
> Thanks. The patch looks good. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Al, will you please merge it? Thanks!
Already applied, actually...
next prev parent reply other threads:[~2017-01-10 8:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 1:34 [PATCH] tmpfs: clear S_ISGID when setting posix ACLs Gu Zheng
2017-01-10 8:03 ` Jan Kara
2017-01-10 8:12 ` Al Viro [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-06 8:12 Gu Zheng
2017-01-06 10:10 ` Jan Kara
2017-01-09 1:26 ` Gu Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110081207.GO1555@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=guzheng1@huawei.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=zhaohongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox