From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965645AbdAJIML (ORCPT <rfc822;w@1wt.eu>);
        Tue, 10 Jan 2017 03:12:11 -0500
Received: from zeniv.linux.org.uk ([195.92.253.2]:53468 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933016AbdAJIMJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 10 Jan 2017 03:12:09 -0500
Date: Tue, 10 Jan 2017 08:12:07 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        zhaohongjiang@huawei.com, miaoxie@huawei.com,
        Gu Zheng <guzheng1@huawei.com>
Subject: Re: [PATCH] tmpfs: clear S_ISGID when setting posix ACLs
Message-ID: <20170110081207.GO1555@ZenIV.linux.org.uk>
References: <1483925688-8233-1-git-send-email-guzheng1@huawei.com>
 <20170110080301.GA32191@quack2.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170110080301.GA32191@quack2.suse.cz>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 10, 2017 at 09:03:01AM +0100, Jan Kara wrote:
> On Mon 09-01-17 09:34:48, Gu Zheng wrote:
> > This change was missed the tmpfs modification in In CVE-2016-7097
> > commit 073931017b49 ("posix_acl: Clear SGID bit when setting
> > file permissions")
> > It can test by xfstest generic/375, which failed to clear
> > setgid bit in the following test case on tmpfs:
> > 
> >   touch $testfile
> >   chown 100:100 $testfile
> >   chmod 2755 $testfile
> >   _runas -u 100 -g 101 -- setfacl -m u::rwx,g::rwx,o::rwx $testfile
> > 
> > Signed-off-by: Gu Zheng <guzheng1@huawei.com>
> 
> Thanks. The patch looks good. You can add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>
> 
> Al, will you please merge it? Thanks!

Already applied, actually...