From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935043AbdAJIG1 (ORCPT ); Tue, 10 Jan 2017 03:06:27 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:52772 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933016AbdAJIGZ (ORCPT ); Tue, 10 Jan 2017 03:06:25 -0500 Date: Tue, 10 Jan 2017 09:06:21 +0100 From: Boris Brezillon To: Punnaiah Choudary Kalluri Cc: Rob Herring , "dwmw2@infradead.org" , "computersforpeace@gmail.com" , "marek.vasut@gmail.com" , "richard@nod.at" , "cyrille.pitchen@atmel.com" , "mark.rutland@arm.com" , "linux-kernel@vger.kernel.org" , "linux-mtd@lists.infradead.org" , "devicetree@vger.kernel.org" , Michal Simek , "kalluripunnaiahchoudary@gmail.com" , "kpc528@gmail.com" Subject: Re: [PATCH v7 1/2] mtd: arasan: Add device tree binding documentation Message-ID: <20170110090621.09d08cfa@bbrezillon> In-Reply-To: <03CA77BA8AF6F1469AEDFBDA1322A7B76424ECD2@XAP-PVEXMBX02.xlnx.xilinx.com> References: <1483930734-10309-1-git-send-email-punnaia@xilinx.com> <20170110053605.yqclykdgi3tgndnp@rob-hp-laptop> <03CA77BA8AF6F1469AEDFBDA1322A7B76424ECD2@XAP-PVEXMBX02.xlnx.xilinx.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Punnaiah, On Tue, 10 Jan 2017 06:03:25 +0000 Punnaiah Choudary Kalluri wrote: > Hi Rob, > > Thanks for the review. > > > -----Original Message----- > > From: Rob Herring [mailto:robh@kernel.org] > > Sent: Tuesday, January 10, 2017 11:06 AM > > To: Punnaiah Choudary Kalluri > > Cc: dwmw2@infradead.org; computersforpeace@gmail.com; > > boris.brezillon@free-electrons.com; marek.vasut@gmail.com; > > richard@nod.at; cyrille.pitchen@atmel.com; mark.rutland@arm.com; linux- > > kernel@vger.kernel.org; linux-mtd@lists.infradead.org; > > devicetree@vger.kernel.org; Michal Simek ; > > kalluripunnaiahchoudary@gmail.com; kpc528@gmail.com; Punnaiah > > Choudary Kalluri > > Subject: Re: [PATCH v7 1/2] mtd: arasan: Add device tree binding > > documentation > > > > On Mon, Jan 09, 2017 at 08:28:53AM +0530, Punnaiah Choudary Kalluri wrote: > > > This patch adds the dts binding document for arasan nand flash > > > controller. > > > > > > Signed-off-by: Punnaiah Choudary Kalluri > > > --- > > > Changes in v7: > > > - Corrected the acronyms those should be in caps > > > changes in v6: > > > - Removed num-cs property > > > - Separated nandchip from nand controller > > > changes in v5: > > > - None > > > Changes in v4: > > > - Added num-cs property > > > - Added clock support > > > Changes in v3: > > > - None > > > Changes in v2: > > > - None > > > --- > > > .../devicetree/bindings/mtd/arasan_nfc.txt | 38 > > ++++++++++++++++++++++ > > > 1 file changed, 38 insertions(+) > > > create mode 100644 > > Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > > > > > diff --git a/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > > new file mode 100644 > > > index 0000000..f20adfc > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > > @@ -0,0 +1,38 @@ > > > +Arasan NAND Flash Controller with ONFI 3.1 support > > > + > > > +Required properties: > > > +- compatible: Should be "arasan,nfc-v3p10" > > > > Needs a note that it must also have an SoC specific compatible string. > > > Sorry, I couldn't understand this comment. Could you elaborate it? Arasan is an IP vendor, and those IPs are usually embedded in specific SoCs. I guess Rob was suggesting to define something like: compatible = ",", "arasan,"; This way you can differentiate minor changes/tweaks between each SoC (each SoC vendor usually enable/disable specific features based on their needs). > > > > +- reg: Memory map for module access > > > +- interrupt-parent: Interrupt controller the interrupt is routed through > > > +- interrupts: Should contain the interrupt for the device > > > +- clock-name: List of input clocks - "clk_sys", "clk_flash" > > > > clk_ is redundant. > > > > I have defined these clock names as per the controller data sheet. > So, I feel it is fine to have them in sync with the datasheet. > Please let me know if you still want me to change this. We already know this is a clock, hence the unneeded clk_ prefix. Please drop it. Thanks, Boris