From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765278AbdAJQk6 (ORCPT ); Tue, 10 Jan 2017 11:40:58 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:35576 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764133AbdAJQkz (ORCPT ); Tue, 10 Jan 2017 11:40:55 -0500 Date: Tue, 10 Jan 2017 17:40:51 +0100 From: Johan Hovold To: Roman Sommer Cc: linux-kernel@i4.cs.fau.de, Rui Miguel Silva , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Christian Bewermeyer Subject: Re: [PATCH] greybus: checkpatch: Change parameter type unsigned to unsigned int Message-ID: <20170110164051.GE3501@localhost> References: <1484065284-27211-1-git-send-email-roman.sommer@fau.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484065284-27211-1-git-send-email-roman.sommer@fau.de> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 10, 2017 at 05:21:24PM +0100, Roman Sommer wrote: > From: Christian Bewermeyer > > Note that this patch does not fix all checkpatch warnings for > gpio.c Fair enough, but you are fixing all of these new "unsigned int" warnings in that driver, right? How about fixing the sole remaining instance in the loopback driver so that this is done for the whole subsystem once and for all? Also your Subject should be staging: greybus: gpio: fix checkpatch unsigned warnings unless doing this subsystem-wide, in which case you can drop the "gpio" module prefix. Thanks, Johan