From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161726AbdAJROt (ORCPT ); Tue, 10 Jan 2017 12:14:49 -0500 Received: from 8bytes.org ([81.169.241.247]:50858 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755547AbdAJROr (ORCPT ); Tue, 10 Jan 2017 12:14:47 -0500 Date: Tue, 10 Jan 2017 18:14:44 +0100 From: Joerg Roedel To: Auger Eric Cc: eric.auger.pro@gmail.com, christoffer.dall@linaro.org, marc.zyngier@arm.com, robin.murphy@arm.com, alex.williamson@redhat.com, will.deacon@arm.com, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, drjones@redhat.com, linux-kernel@vger.kernel.org, pranav.sawargaonkar@gmail.com, iommu@lists.linux-foundation.org, punit.agrawal@arm.com, diana.craciun@nxp.com, gpkulkarni@gmail.com, shankerd@codeaurora.org, bharat.bhushan@nxp.com, geethasowjanya.akula@gmail.com Subject: Re: [PATCH v7 08/19] iommu: Implement reserved_regions iommu-group sysfs file Message-ID: <20170110171444.GU17255@8bytes.org> References: <1483969570-3154-1-git-send-email-eric.auger@redhat.com> <1483969570-3154-9-git-send-email-eric.auger@redhat.com> <9ee5aa6b-6e63-c153-0727-729e0e9592c6@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9ee5aa6b-6e63-c153-0727-729e0e9592c6@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 10, 2017 at 05:20:34PM +0100, Auger Eric wrote: > The /sys/kernel/iommu_groups/n directory seems to be removed before this > gets called and this may produce a WARNING when devices get removed from > the group. I intend to remove the call since I have the feeling > everything gets cleaned up properly. A feeling is not enough, please check that in the code. Joerg