From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941859AbdAJRhX (ORCPT ); Tue, 10 Jan 2017 12:37:23 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:39312 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932797AbdAJRhV (ORCPT ); Tue, 10 Jan 2017 12:37:21 -0500 Date: Tue, 10 Jan 2017 18:37:41 +0100 From: Greg KH To: Corentin Labbe Cc: davem@davemloft.net, sparclinux@vger.kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sbus: char: Move D7S_MINOR to include/linux/miscdevice.h Message-ID: <20170110173741.GC1340@kroah.com> References: <20161215194703.11195-1-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161215194703.11195-1-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 15, 2016 at 08:47:03PM +0100, Corentin Labbe wrote: > This patch move the define for D7S_MINOR to include/linux/miscdevice.h. > It's better that all minor number are in the same place. > > Signed-off-by: Corentin Labbe > --- > drivers/sbus/char/display7seg.c | 1 - > include/linux/miscdevice.h | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/sbus/char/display7seg.c b/drivers/sbus/char/display7seg.c > index 33fbe82..48a5df0 100644 > --- a/drivers/sbus/char/display7seg.c > +++ b/drivers/sbus/char/display7seg.c > @@ -22,7 +22,6 @@ > > #include > > -#define D7S_MINOR 193 > #define DRIVER_NAME "d7s" > #define PFX DRIVER_NAME ": " > > diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h > index 5385d95..b1ba37aef 100644 > --- a/include/linux/miscdevice.h > +++ b/include/linux/miscdevice.h > @@ -33,6 +33,7 @@ > #define I2O_MINOR 166 > #define HWRNG_MINOR 183 > #define MICROCODE_MINOR 184 > +#define D7S_MINOR 193 > #define VFIO_MINOR 196 > #define TUN_MINOR 200 > #define CUSE_MINOR 203 > -- Doesn't apply to my tree :(