From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755397AbdAJWYw (ORCPT ); Tue, 10 Jan 2017 17:24:52 -0500 Received: from mail.gondor.com ([78.47.100.206]:34041 "EHLO mail1.gondor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752751AbdAJWYr (ORCPT ); Tue, 10 Jan 2017 17:24:47 -0500 Date: Tue, 10 Jan 2017 23:24:38 +0100 From: Jan Niehusmann To: Paul Menzel Cc: Linux Kernel Mailing List , Thorsten Leemhuis , Daniel Blueman , Len Brown , Tomas Winkler , Alexander Usyskin , Greg Kroah-Hartman Subject: Re: Dell XPS13 does not suspend with Linux 4.10-rc3 Message-ID: <20170110222437.GA3022@x61s.reliablesolutions.de> References: <7b1ba8e4-03b2-8a73-603b-63cce6403c31@molgen.mpg.de> <20170110204331.GA3974@x61s.reliablesolutions.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170110204331.GA3974@x61s.reliablesolutions.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote: > And I bisected the issue to commit 7279b238ba, "mei: send OS type to the > FW" Indeed, just disabling the FIXUP implemented by that commit fixes suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s. (For the addressees newly added to cc, it seems like the mentioned commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s) --- a/drivers/misc/mei/bus-fixup.c +++ b/drivers/misc/mei/bus-fixup.c @@ -406,3 +406,3 @@ static struct mei_fixup { MEI_FIXUP(MEI_UUID_WD, mei_wd), - MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix), +// MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix), }; I don't know what this may break, as the description of 7279b23 just says: "This workaround was added to support other broken OS and we need to follow here." Unless there is a better justification, I think the commit should be reverted, for now. Jan