From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936255AbdAKIAr (ORCPT ); Wed, 11 Jan 2017 03:00:47 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:33108 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934856AbdAKIAf (ORCPT ); Wed, 11 Jan 2017 03:00:35 -0500 Date: Wed, 11 Jan 2017 09:00:55 +0100 From: Greg Kroah-Hartman To: Jason Uy Cc: Jiri Slaby , Andy Shevchenko , Kefeng Wang , Noam Camus , Heikki Krogerus , Wang Hongcheng , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH v1 1/1] serial: 8250_dw: Allow hardware flow control to be used Message-ID: <20170111080055.GA8548@kroah.com> References: <1481063643-11951-1-git-send-email-jason.uy@broadcom.com> <1481063643-11951-2-git-send-email-jason.uy@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481063643-11951-2-git-send-email-jason.uy@broadcom.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 06, 2016 at 02:34:03PM -0800, Jason Uy wrote: > In the most common use case, the Synopsys DW UART driver does not > set the set_termios callback function. This prevents UPSTAT_AUTOCTS > from being set when the UART flag CRTSCTS is set. As a result, the > driver will use software flow control as opposed to hardware flow > control. > > To fix the problem, the set_termios callback function is set to the > DW specific function. The logic to set UPSTAT_AUTOCTS is moved so > that any clock error will not affect setting the hardware flow > control. > > Reviewed-by: Scott Branden > Reviewed-by: Ray Jui > Signed-off-by: Jason Uy > --- > drivers/tty/serial/8250/8250_dw.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) This patch doesn't apply at all to the latest kernel tree. Can you please refresh it and resend? thanks, greg k-h