From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org, Peter Pan <peterpansjtu@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
linux-kernel@vger.kernel.org,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
Kelvin Cheung <keguang.zhang@gmail.com>
Subject: Re: [PATCH v3 4/7] mtd: nand: raw: prefix conflicting names with nandc instead of nand
Date: Wed, 11 Jan 2017 08:46:13 +0100 [thread overview]
Message-ID: <20170111084613.69e80a40@bbrezillon> (raw)
In-Reply-To: <8fb86bb7-425a-3897-2d1d-7277e94918ec@gmail.com>
On Tue, 10 Jan 2017 20:08:23 +0100
Marek Vasut <marek.vasut@gmail.com> wrote:
> On 11/21/2016 01:45 PM, Boris Brezillon wrote:
> > Some raw NAND function names conflict with names defined in nand.h.
> > Prefix all those functions with nandc (for nand chip) instead of nand so
> > we can include nand.h from rawnand.h
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> Nit, nand and nandc is quite confusing, why not call it nand_chip in full?
>
Indeed, the name is confusing as hell, I just tried to keep it
short but that's probably not a good idea.
Maybe I should just prefix/suffix the new functions with nanddev instead
of changing the existing ones. What do you think?
next prev parent reply other threads:[~2017-01-11 7:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 12:45 [PATCH v3 0/7] mtd: nand: Abstract away the NAND interface type Boris Brezillon
2016-11-21 12:45 ` [PATCH v3 1/7] mtd: nand: Rename nand.h into rawnand.h Boris Brezillon
2016-11-21 12:45 ` [PATCH v3 2/7] mtd: nand: move raw NAND related code to the raw/ subdir Boris Brezillon
2016-11-21 12:45 ` [PATCH v3 3/7] mtd: nand: add a nand.h file to expose basic NAND stuff Boris Brezillon
2016-11-21 12:45 ` [PATCH v3 4/7] mtd: nand: raw: prefix conflicting names with nandc instead of nand Boris Brezillon
2017-01-10 19:08 ` Marek Vasut
2017-01-11 7:46 ` Boris Brezillon [this message]
2017-01-11 12:09 ` Marek Vasut
2017-01-11 12:39 ` Boris Brezillon
2017-01-11 13:08 ` Marek Vasut
2017-01-11 13:14 ` Boris Brezillon
2017-01-11 13:21 ` Marek Vasut
2016-11-21 12:45 ` [PATCH v3 5/7] mtd: nand: raw: create struct rawnand_device Boris Brezillon
2017-01-10 19:09 ` Marek Vasut
2017-01-11 7:48 ` Boris Brezillon
2016-11-21 12:45 ` [PATCH v3 6/7] mtd: nand: raw: make BBT code more generic Boris Brezillon
2016-11-21 12:45 ` [PATCH v3 7/7] mtd: nand: move BBT code to drivers/mtd/nand/ Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111084613.69e80a40@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=keguang.zhang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=peterpansjtu@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox