From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760635AbdAKHqR (ORCPT ); Wed, 11 Jan 2017 02:46:17 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:43018 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750819AbdAKHqQ (ORCPT ); Wed, 11 Jan 2017 02:46:16 -0500 Date: Wed, 11 Jan 2017 08:46:13 +0100 From: Boris Brezillon To: Marek Vasut Cc: Richard Weinberger , linux-mtd@lists.infradead.org, Peter Pan , David Woodhouse , Brian Norris , Cyrille Pitchen , linux-kernel@vger.kernel.org, Ezequiel Garcia , Kelvin Cheung Subject: Re: [PATCH v3 4/7] mtd: nand: raw: prefix conflicting names with nandc instead of nand Message-ID: <20170111084613.69e80a40@bbrezillon> In-Reply-To: <8fb86bb7-425a-3897-2d1d-7277e94918ec@gmail.com> References: <1479732328-18363-1-git-send-email-boris.brezillon@free-electrons.com> <1479732328-18363-5-git-send-email-boris.brezillon@free-electrons.com> <8fb86bb7-425a-3897-2d1d-7277e94918ec@gmail.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 10 Jan 2017 20:08:23 +0100 Marek Vasut wrote: > On 11/21/2016 01:45 PM, Boris Brezillon wrote: > > Some raw NAND function names conflict with names defined in nand.h. > > Prefix all those functions with nandc (for nand chip) instead of nand so > > we can include nand.h from rawnand.h > > > > Signed-off-by: Boris Brezillon > > Nit, nand and nandc is quite confusing, why not call it nand_chip in full? > Indeed, the name is confusing as hell, I just tried to keep it short but that's probably not a good idea. Maybe I should just prefix/suffix the new functions with nanddev instead of changing the existing ones. What do you think?