From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936756AbdAKI4a (ORCPT ); Wed, 11 Jan 2017 03:56:30 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:35246 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936708AbdAKI42 (ORCPT ); Wed, 11 Jan 2017 03:56:28 -0500 Date: Wed, 11 Jan 2017 00:56:25 -0800 From: Christoph Hellwig To: Bart Van Assche Cc: Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Borntraeger , Joerg Roedel , Andy Lutomirski , "Michael S . Tsirkin" Subject: Re: [PATCH 3/9] dma: Add dma_virt_ops Message-ID: <20170111085625.GA15575@infradead.org> References: <20170111005648.14988-1-bart.vanassche@sandisk.com> <20170111005648.14988-4-bart.vanassche@sandisk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170111005648.14988-4-bart.vanassche@sandisk.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > +lib-$(CONFIG_HAS_DMA) += dma-virt.o There probably should be a config option for it for two reasons: - do not bloat kernels that don't need it. - the feature can only work for 32-bit architectures or for 64-bit architectures that set ARCH_DMA_ADDR_T_64BIT… Altenatiely this option would have to force ARCH_DMA_ADDR_T_64BIT when not yet set for 64-bit architectures. And yes, this is currently broken already for, but we'd better fix it.