From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755964AbdAKJgE (ORCPT <rfc822;w@1wt.eu>);
        Wed, 11 Jan 2017 04:36:04 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:40036 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750743AbdAKJgC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Jan 2017 04:36:02 -0500
Date: Wed, 11 Jan 2017 10:36:22 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Jan Niehusmann <jan@gondor.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Thorsten Leemhuis <linux@leemhuis.info>,
        Daniel Blueman <daniel@quora.org>, Len Brown <len.brown@intel.com>,
        Tomas Winkler <tomas.winkler@intel.com>,
        Alexander Usyskin <alexander.usyskin@intel.com>
Subject: Re: Dell XPS13 does not suspend with Linux 4.10-rc3
Message-ID: <20170111093622.GA16662@kroah.com>
References: <7b1ba8e4-03b2-8a73-603b-63cce6403c31@molgen.mpg.de>
 <20170110204331.GA3974@x61s.reliablesolutions.de>
 <20170110222437.GA3022@x61s.reliablesolutions.de>
 <384df4ea-8a3e-0db3-c057-e8ef46912504@molgen.mpg.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <384df4ea-8a3e-0db3-c057-e8ef46912504@molgen.mpg.de>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 11, 2017 at 09:53:38AM +0100, Paul Menzel wrote:
> Dear Linux folks,
> 
> 
> On 01/10/17 23:24, Jan Niehusmann wrote:
> > On Tue, Jan 10, 2017 at 09:43:31PM +0100, Jan Niehusmann wrote:
> > > And I bisected the issue to commit 7279b238ba, "mei: send OS type to the
> > > FW"
> > 
> > Indeed, just disabling the FIXUP implemented by that commit fixes
> > suspend for me, with 4.10.0-rc3. Btw, this is on a Thinkpad x201s.
> > 
> > (For the addressees newly added to cc, it seems like the mentioned
> > commit breaks suspend to ram on Dell XPS13 and Thinkpad x201s)
> > 
> > --- a/drivers/misc/mei/bus-fixup.c
> > +++ b/drivers/misc/mei/bus-fixup.c
> > @@ -406,3 +406,3 @@ static struct mei_fixup {
> >         MEI_FIXUP(MEI_UUID_WD, mei_wd),
> > -       MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> > +//     MEI_FIXUP(MEI_UUID_MKHIF_FIX, mei_mkhi_fix),
> >  };
> > 
> > 
> > I don't know what this may break, as the description of 7279b23 just
> > says:
> > "This workaround was added to support other broken OS and we need to
> > follow here."
> > 
> > Unless there is a better justification, I think the commit should be
> > reverted, for now.
> 
> Somebody else already created the bug 192051 in the Linux Kernel Bug Tracker
> [1].

There's a fix for this in my tree to go to Linus for 4.10-rc4.

thanks,

greg k-h