From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966516AbdAKNPk (ORCPT <rfc822;w@1wt.eu>);
        Wed, 11 Jan 2017 08:15:40 -0500
Received: from mail.free-electrons.com ([62.4.15.54]:48702 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S966174AbdAKNOn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 11 Jan 2017 08:14:43 -0500
Date: Wed, 11 Jan 2017 14:14:40 +0100
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org,
        Peter Pan <peterpansjtu@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Cyrille Pitchen <cyrille.pitchen@atmel.com>,
        linux-kernel@vger.kernel.org,
        Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
        Kelvin Cheung <keguang.zhang@gmail.com>
Subject: Re: [PATCH v3 4/7] mtd: nand: raw: prefix conflicting names with
 nandc instead of nand
Message-ID: <20170111141440.5f50f32d@bbrezillon>
In-Reply-To: <71d834f0-ff23-4a0d-2554-83ebd4855999@gmail.com>
References: <1479732328-18363-1-git-send-email-boris.brezillon@free-electrons.com>
        <1479732328-18363-5-git-send-email-boris.brezillon@free-electrons.com>
        <8fb86bb7-425a-3897-2d1d-7277e94918ec@gmail.com>
        <20170111084613.69e80a40@bbrezillon>
        <47760b42-607c-bcae-18b9-3ede5773125a@gmail.com>
        <20170111133933.0752c003@bbrezillon>
        <71d834f0-ff23-4a0d-2554-83ebd4855999@gmail.com>
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 11 Jan 2017 14:08:02 +0100
Marek Vasut <marek.vasut@gmail.com> wrote:

> On 01/11/2017 01:39 PM, Boris Brezillon wrote:
> > On Wed, 11 Jan 2017 13:09:09 +0100
> > Marek Vasut <marek.vasut@gmail.com> wrote:
> >   
> >> On 01/11/2017 08:46 AM, Boris Brezillon wrote:  
> >>> On Tue, 10 Jan 2017 20:08:23 +0100
> >>> Marek Vasut <marek.vasut@gmail.com> wrote:
> >>>     
> >>>> On 11/21/2016 01:45 PM, Boris Brezillon wrote:    
> >>>>> Some raw NAND function names conflict with names defined in nand.h.
> >>>>> Prefix all those functions with nandc (for nand chip) instead of nand so
> >>>>> we can include nand.h from rawnand.h
> >>>>>
> >>>>> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>      
> >>>>
> >>>> Nit, nand and nandc is quite confusing, why not call it nand_chip in full?
> >>>>    
> >>>
> >>> Indeed, the name is confusing as hell, I just tried to keep it
> >>> short but that's probably not a good idea.
> >>> Maybe I should just prefix/suffix the new functions with nanddev instead
> >>> of changing the existing ones. What do you think?    
> >>
> >> That'd be less intrusive, but tbh, if the name is descriptive enough, I
> >> don't care either way. What does 'nanddev' imply though ? NAND device as
> >> in physical device or chip or just a kernel device object ? :-)
> >>  
> > 
> > Physical device, but it's also exposed as a kernel dev object by the
> > MTD layer.  
> 
> So I guess nandchip if it's supposed to be physical device then.
> 

You mean s/nandc/nandchip/, right? I'm fine with that.