From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755585AbdAKWR7 (ORCPT ); Wed, 11 Jan 2017 17:17:59 -0500 Received: from mga02.intel.com ([134.134.136.20]:26895 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754739AbdAKWR6 (ORCPT ); Wed, 11 Jan 2017 17:17:58 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,347,1477983600"; d="scan'208";a="807795978" Date: Wed, 11 Jan 2017 14:17:56 -0800 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] perf, tools: Add probing for xed Message-ID: <20170111221756.GG8388@tassilo.jf.intel.com> References: <20170110010225.24870-1-andi@firstfloor.org> <20170110010225.24870-2-andi@firstfloor.org> <20170111183714.GB29004@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170111183714.GB29004@krava> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature > > index e3fb5ecbdcb6..971a9ef87ca6 100644 > > --- a/tools/build/Makefile.feature > > +++ b/tools/build/Makefile.feature > > @@ -63,7 +63,7 @@ FEATURE_TESTS_BASIC := \ > > lzma \ > > get_cpuid \ > > bpf \ > > - sdt > > + sdt \ > > looks like you forgot to add xed in here? why the '\' ? I removed it, but incompletely. > anyway, please add it in here so it's visible under make VF=1 If I add it here then it is shown by default (even without VF=1). Arnaldo requested earlier that it shouldn't be shown. -Andi