From: Greg KH <gregkh@linuxfoundation.org>
To: Bogdan Purcareata <bogdan.purcareata@gmail.com>
Cc: labbott@redhat.com, sumit.semwal@linaro.org, arve@android.com,
riandrews@android.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: android/ion: Fix coding style issues
Date: Thu, 12 Jan 2017 08:36:15 +0100 [thread overview]
Message-ID: <20170112073615.GB23347@kroah.com> (raw)
In-Reply-To: <1484169639-18408-1-git-send-email-bogdan.purcareata@gmail.com>
On Wed, Jan 11, 2017 at 11:20:39PM +0200, Bogdan Purcareata wrote:
> Fix following checkpatch warnings:
> - Lines over 80 characters
> - void function with return statement
> - Unaligned comment mark
> - Header function prototypes missing variable names
That's a lot of different things to be doing all in one patch. Please
break this up into "one-logical-thing-per-patch" and send this as a
patch series.
And no, "fix coding style issues" is not "one logical thing".
thanks,
greg k-h
next prev parent reply other threads:[~2017-01-12 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 21:20 [PATCH] staging: android/ion: Fix coding style issues Bogdan Purcareata
2017-01-12 7:36 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-10 21:40 Bogdan Purcareata
2017-01-10 21:47 ` Greg KH
2017-01-10 22:12 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112073615.GB23347@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=bogdan.purcareata@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox