public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Fabian Arnold <fabian.arnold@fau.de>
Cc: devel@linuxdriverproject.org,
	Philip Thiemann <philip.thiemann@fau.de>,
	linux-kernel@i4.cs.fau.de, linux-kernel@vger.kernel.org,
	Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH] tty_port: checkpatch: Refactored file to linux style guides
Date: Thu, 12 Jan 2017 08:49:35 +0100	[thread overview]
Message-ID: <20170112074935.GC23943@kroah.com> (raw)
In-Reply-To: <1484170762-25002-1-git-send-email-fabian.arnold@fau.de>

On Wed, Jan 11, 2017 at 10:39:22PM +0100, Fabian Arnold wrote:
> The tty_port.c file is now accordingly to the linux style guidelines.

That's the vaguest changelog text ever :(

Please describe what you did here, and why you did it.  And if you fixed
more than one "type" of style issue, you need to break this up into
multiple patches.

And finally, why are you doing checkpatch cleanup on core kernel code?
Please start in drivers/staging/ where it's more appreciated and you can
learn how to do it correctly, that's what that code is there for.

thanks,

greg k-h

      reply	other threads:[~2017-01-12  7:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11 21:39 [PATCH] tty_port: checkpatch: Refactored file to linux style guides Fabian Arnold
2017-01-12  7:49 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170112074935.GC23943@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@linuxdriverproject.org \
    --cc=fabian.arnold@fau.de \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=philip.thiemann@fau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox