From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750952AbdALHtP (ORCPT ); Thu, 12 Jan 2017 02:49:15 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:38424 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750727AbdALHtO (ORCPT ); Thu, 12 Jan 2017 02:49:14 -0500 Date: Thu, 12 Jan 2017 08:49:35 +0100 From: Greg Kroah-Hartman To: Fabian Arnold Cc: devel@linuxdriverproject.org, Philip Thiemann , linux-kernel@i4.cs.fau.de, linux-kernel@vger.kernel.org, Jiri Slaby Subject: Re: [PATCH] tty_port: checkpatch: Refactored file to linux style guides Message-ID: <20170112074935.GC23943@kroah.com> References: <1484170762-25002-1-git-send-email-fabian.arnold@fau.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484170762-25002-1-git-send-email-fabian.arnold@fau.de> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2017 at 10:39:22PM +0100, Fabian Arnold wrote: > The tty_port.c file is now accordingly to the linux style guidelines. That's the vaguest changelog text ever :( Please describe what you did here, and why you did it. And if you fixed more than one "type" of style issue, you need to break this up into multiple patches. And finally, why are you doing checkpatch cleanup on core kernel code? Please start in drivers/staging/ where it's more appreciated and you can learn how to do it correctly, that's what that code is there for. thanks, greg k-h