From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751010AbdALImo (ORCPT ); Thu, 12 Jan 2017 03:42:44 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34778 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750894AbdALIml (ORCPT ); Thu, 12 Jan 2017 03:42:41 -0500 Date: Thu, 12 Jan 2017 09:41:42 +0100 From: Ingo Molnar To: Andy Shevchenko Cc: Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" , linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 1/1] x86/kernel: Update bug_at() head message Message-ID: <20170112084142.GA10813@gmail.com> References: <20170110164354.47372-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170110164354.47372-1-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andy Shevchenko wrote: > First of all, %*ph specifier allows to dump data in hex format using the > pointer to a buffer. This is suitable to use here. > > Besides that Thomas suggested to move it to critical level and replace __FILE__ > by explicit mention of "jumplabel". > > Signed-off-by: Andy Shevchenko > --- > arch/x86/kernel/jump_label.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c > index fc25f698d792..32f126e726f5 100644 > --- a/arch/x86/kernel/jump_label.c > +++ b/arch/x86/kernel/jump_label.c > @@ -32,8 +32,7 @@ static void bug_at(unsigned char *ip, int line) > * Something went wrong. Crash the box, as something could be > * corrupting the kernel. > */ > - pr_warning("Unexpected op at %pS [%p] (%02x %02x %02x %02x %02x) %s:%d\n", > - ip, ip, ip[0], ip[1], ip[2], ip[3], ip[4], __FILE__, line); > + pr_crit("jumplabel: Unexpected op at %pS [%p] (%5ph) %d\n", ip, ip, ip, line); > BUG(); What is 'jumplabel'? Nobody calls it that in the kernel - everyone calls it 'jump_label' ... (Fixed that in patch, no need to resend.) Thanks, Ingo