From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751635AbdALMM0 (ORCPT ); Thu, 12 Jan 2017 07:12:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45894 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbdALMMZ (ORCPT ); Thu, 12 Jan 2017 07:12:25 -0500 Date: Thu, 12 Jan 2017 13:12:22 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org Subject: Re: Support Intel uncore event lists v4 Message-ID: <20170112121222.GA7959@krava> References: <20170110013337.4876-1-andi@firstfloor.org> <20170111185344.GA21289@krava> <20170111195258.GE26852@two.firstfloor.org> <20170111214732.GA24030@krava> <20170111215406.GF26852@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170111215406.GF26852@two.firstfloor.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 12 Jan 2017 12:12:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2017 at 01:54:07PM -0800, Andi Kleen wrote: > On Wed, Jan 11, 2017 at 10:47:32PM +0100, Jiri Olsa wrote: > > On Wed, Jan 11, 2017 at 11:52:58AM -0800, Andi Kleen wrote: > > > > > v1: Initial post > > > > > v2: Address review feedback. See changelog in commits. > > > > > v3: Repost. Rebase to latest tree. > > > > > v4: Rebase. Change DividedBy to generic simple expression parser. > > > > > Fix refactoring problem that broke git bisect. > > > > > Address review feedback. > > > > > > > > > > > > > what's the difference to the post from Jan 03? > > > > > > Jan 03 was v3 I think? > > > > > > Also I addressed all your review comments (listed in the individual > > > patches) > > > > 6012 Jan 03 Andi Kleen (1.5K) Support Intel uncore event lists v4 > > 6421 r Jan 09 Andi Kleen (1.5K) Support Intel uncore event lists v4 > > > > the messages seem identical > > Hmm I messed up the version number then. This should be version number > 5 then. > > It was supposed to fix your review feedback for the earlier series > and add Acked-by. > > I listed the (minor) changes in the individual patches. > > perf, tools: Add support for parsing uncore json files > v3: Remove extra __maybe_unused > > perf, tools: Factor out scale conversion code > v3: Use ENOMEM, not -1. > > Really only trivial changes at this point, so you only need to read > the patches you didn't read and ack before. any chance you'd push the new branch out? thanks, jirka