From: Nicholas Mc Guire <der.herr@hofr.at>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
John Youn <johnyoun@synopsys.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: dwc2: host: fix Wmaybe-uninitialized warning
Date: Thu, 12 Jan 2017 16:31:59 +0000 [thread overview]
Message-ID: <20170112163159.GA25260@osadl.at> (raw)
In-Reply-To: <20170112162500.GA10283@kroah.com>
On Thu, Jan 12, 2017 at 05:25:00PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Jan 12, 2017 at 04:54:38PM +0100, Nicholas Mc Guire wrote:
> > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> > ---
> > Problem reported by sparse
> > drivers/usb/dwc2/hcd.c: In function 'dwc2_dump_urb_info':
> > ./include/linux/dynamic_debug.h:134:3: warning: 'pipetype' may be used uninitialized in this function [-Wmaybe-uninitialized]
> > __dynamic_dev_dbg(&descriptor, dev, fmt, \
> > ^
> > drivers/usb/dwc2/hcd.c:4492:8: note: 'pipetype' was declared here
> > char *pipetype;
> > ^
> > Patch was compile tested with: x86_64_defconfig + CONFIG_USB_DWC2=m +
> > CONFIG_USB_DWC2_VERBOSE=y
>
> Put the above in the changelog text please, I can't take patches without
> any changelog text :(
>
sorry - simply forgot to put that in - just resent as V2
thx!
hofrat
prev parent reply other threads:[~2017-01-12 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 15:54 [PATCH] usb: dwc2: host: fix Wmaybe-uninitialized warning Nicholas Mc Guire
2017-01-12 16:25 ` Greg Kroah-Hartman
2017-01-12 16:31 ` Nicholas Mc Guire [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112163159.GA25260@osadl.at \
--to=der.herr@hofr.at \
--cc=gregkh@linuxfoundation.org \
--cc=hofrat@osadl.org \
--cc=johnyoun@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox