From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750900AbdALWYw (ORCPT ); Thu, 12 Jan 2017 17:24:52 -0500 Received: from shells.gnugeneration.com ([66.240.222.126]:33244 "HELO shells.gnugeneration.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750808AbdALWYv (ORCPT ); Thu, 12 Jan 2017 17:24:51 -0500 Date: Thu, 12 Jan 2017 16:24:50 -0600 From: lkml@pengaru.com To: Chris Wilson , linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, "# v4 . 10-rc1+" Subject: Re: [PATCH v2] drm/i915: Flush untouched framebuffers before display on !llc Message-ID: <20170112222450.GE32751@shells.gnugeneration.com> References: <20170109063240.GB9125@shells.gnugeneration.com> <20170109111932.6342-1-chris@chris-wilson.co.uk> <20170112211706.GC28328@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170112211706.GC28328@nuc-i3427.alporthouse.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2017 at 09:17:06PM +0000, Chris Wilson wrote: > On Mon, Jan 09, 2017 at 11:19:32AM +0000, Chris Wilson wrote: > > On a non-llc system, the objects are created with .cache_level = > > CACHE_NONE and so the transition to uncached for scanout is a no-op. > > However, if the object was never written to, it will still be in the CPU > > domain (having been zeroed out by shmemfs). Those cachelines need to be > > flushed prior to display. > > > > Reported-by: Vito Caputo > > Fixes: a6a7cc4b7db6 ("drm/i915: Always flush the dirty CPU cache when pinning the scanout") > > Signed-off-by: Chris Wilson > > Cc: # v4.10-rc1+ > > Ping? This patch fixes the problem for me, in case that's what the ping's for. Out of curiosity the bug I reported described here be getting fixed in 4.10? https://lists.freedesktop.org/archives/dri-devel/2017-January/128405.html Thanks. > > > --- > > drivers/gpu/drm/i915/i915_gem.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c > > index 76689b59fc90..bdb113ef8cfe 100644 > > --- a/drivers/gpu/drm/i915/i915_gem.c > > +++ b/drivers/gpu/drm/i915/i915_gem.c > > @@ -3514,7 +3514,7 @@ i915_gem_object_pin_to_display_plane(struct drm_i915_gem_object *obj, > > vma->display_alignment = max_t(u64, vma->display_alignment, alignment); > > > > /* Treat this as an end-of-frame, like intel_user_framebuffer_dirty() */ > > - if (obj->cache_dirty) { > > + if (obj->cache_dirty || obj->base.write_domain == I915_GEM_DOMAIN_CPU) { > > i915_gem_clflush_object(obj, true); > > intel_fb_obj_flush(obj, false, ORIGIN_DIRTYFB); > > } > > -- > > 2.11.0 > > -- > Chris Wilson, Intel Open Source Technology Centre