Re: [PATCH] rcu: Narrow early boot window of illegal synchronous grace periods

Paul E. McKenney
2017-01-16T04:57:11Z

On Mon, Jan 16, 2017 at 01:57:25AM +0000, Zheng, Lv wrote:
> Hi,
>
> > From: Borislav Petkov [mailto:bp@alien8.de]
> > Subject: Re: [PATCH] rcu: Narrow early boot window of illegal synchronous grace periods
> >
> > On Sat, Jan 14, 2017 at 01:27:40PM +0100, Rafael J. Wysocki wrote:
> > > OK, so this fixes the problem with synchronize_rcu_expedited() in
> > > acpi_os_map_cleanup(), right?
> >
> > Yeah.
> >
> > > I wonder if the ACPI-specific fix is still needed, then?
> >
> > It is not strictly necessary. If you still think it would be better to
> > have it regardless, you could pick it up. I.e., making ACPI more robust,
> > yadda yadda.
> >
> > I dunno, though, perhaps it is only complicating the code unnecessarily
> > and then can be safely ignored with a mental note for future freezes.
>
> Glad to see it fixed inside of the API provider.
>
> IMO, ACPI fix is unnecessary as ACPI is just a user of the RCU APIs.
> And it's pointless to add special checks in the user side in order to use one of them.

With some luck, the RCU patch will go in sooner rather than later.

Should it be delayed for whatever reason, the ACPI patch might well
be needed in the meantime.

Thanx, Paul