From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751137AbdAMGgE (ORCPT ); Fri, 13 Jan 2017 01:36:04 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34692 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750700AbdAMGgD (ORCPT ); Fri, 13 Jan 2017 01:36:03 -0500 Date: Fri, 13 Jan 2017 15:36:14 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , zhouxianrong@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, sergey.senozhatsky@gmail.com, ngupta@vflare.org, Mi.Sophia.Wang@huawei.com, zhouxiyu@huawei.com, weidu.du@huawei.com, zhangshiming5@huawei.com, won.ho.park@huawei.com Subject: Re: [PATCH] mm: extend zero pages to same element pages for zram Message-ID: <20170113063614.GA484@jagdpanzerIV.localdomain> References: <1483692145-75357-1-git-send-email-zhouxianrong@huawei.com> <20170109234110.GA10298@bbox> <20170113042444.GE9360@jagdpanzerIV.localdomain> <20170113062343.GA7827@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170113062343.GA7827@bbox> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (01/13/17 15:23), Minchan Kim wrote: [..] > > > Please add same_pages to tail of the stat > > > > sounds ok to me. and yes, can deprecate zero_pages. > > > > seems that with that patch the concept of ZRAM_ZERO disappears. both > > ZERO and SAME_ELEMENT pages are considered to be the same thing now. > > Right. > > > which is fine and makes sense to me, I think. and if ->.same_pages will > > replace ->.zero_pages in mm_stat() then I'm also OK. yes, we will see > > increased number in the last column of mm_stat file, but I don't tend > > to see any issues here. Minchan, what do you think? > > Could you elaborate a bit? Do you mean this? > > ret = scnprintf(buf, PAGE_SIZE, > "%8llu %8llu %8llu %8lu %8ld %8llu %8lu\n", > orig_size << PAGE_SHIFT, > (u64)atomic64_read(&zram->stats.compr_data_size), > mem_used << PAGE_SHIFT, > zram->limit_pages << PAGE_SHIFT, > max_used << PAGE_SHIFT, > // (u64)atomic64_read(&zram->stats.zero_pages), > (u64)atomic64_read(&zram->stats.same_pages), > pool_stats.pages_compacted); yes, correct. do we need to export it as two different stats (zero_pages and same_pages), if those are basically same thing internally? -ss