From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751305AbdAMIye (ORCPT ); Fri, 13 Jan 2017 03:54:34 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:45420 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146AbdAMIyc (ORCPT ); Fri, 13 Jan 2017 03:54:32 -0500 DMARC-Filter: OpenDMARC Filter v1.3.1 smtp.codeaurora.org 3309360234 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=pass smtp.mailfrom=sboyd@codeaurora.org Date: Fri, 13 Jan 2017 00:54:30 -0800 From: Stephen Boyd To: Viresh Kumar Cc: Rafael Wysocki , Viresh Kumar , Nishanth Menon , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Vincent Guittot Subject: Re: [PATCH 02/12] PM / OPP: Add 'struct kref' to OPP table Message-ID: <20170113085430.GT17126@codeaurora.org> References: <3f23949c92492ea74a7a55cd04bcd41a37592ed5.1481106919.git.viresh.kumar@linaro.org> <20170109233627.GU17126@codeaurora.org> <20170110042312.GB6332@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170110042312.GB6332@vireshk-i7> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/10, Viresh Kumar wrote: > On 09-01-17, 15:36, Stephen Boyd wrote: > > > It would be better to have _find_opp_table() > > return the pointer with the reference already taken so that we > > don't have to update callers with reference grabbing calls. > > Typically if a function returns a reference counted pointer the > > reference counting has already been done. > > Absolutely, but that happens with later patches in the series. I couldn't have > done it now, as something or the other would have broken. > Ok, if things get better later in the series then you can have my Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project