From: Krzysztof Kozlowski <krzk@kernel.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org,
Laxman Dewangan <ldewangan@nvidia.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH 1/4] mfd: max77686: Don't attempt to get i2c_device_id .data
Date: Fri, 13 Jan 2017 14:56:07 +0200 [thread overview]
Message-ID: <20170113125607.aklab4v3yrbpqrel@kozik-lap> (raw)
In-Reply-To: <1484228857-20182-2-git-send-email-javier@osg.samsung.com>
On Thu, Jan 12, 2017 at 10:47:34AM -0300, Javier Martinez Canillas wrote:
> The driver is only used in platforms that have DT support so always the
> I2C device .data will be get from the matched OF node and never will be
> from the I2C device ID table.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/mfd/max77686.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2017-01-13 12:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 13:47 [PATCH 0/4] mfd: max77686: Remove unneeded non-OF code in driver Javier Martinez Canillas
2017-01-12 13:47 ` [PATCH 1/4] mfd: max77686: Don't attempt to get i2c_device_id .data Javier Martinez Canillas
2017-01-13 12:56 ` Krzysztof Kozlowski [this message]
2017-01-23 11:32 ` Lee Jones
2017-01-12 13:47 ` [PATCH 2/4] mfd: max77686: Use of_device_get_match_data() helper Javier Martinez Canillas
2017-01-13 13:04 ` Krzysztof Kozlowski
2017-01-13 13:12 ` Javier Martinez Canillas
2017-01-12 13:47 ` [PATCH 3/4] mfd: max77686: Use the struct i2c_driver .probe_new instead of .probe Javier Martinez Canillas
2017-01-13 13:11 ` Krzysztof Kozlowski
2017-01-12 13:47 ` [PATCH 4/4] mfd: max77686: Remove I2C device ID table Javier Martinez Canillas
2017-01-13 13:13 ` Krzysztof Kozlowski
2017-01-12 16:22 ` [PATCH 0/4] mfd: max77686: Remove unneeded non-OF code in driver Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113125607.aklab4v3yrbpqrel@kozik-lap \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=javier@osg.samsung.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox