From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751806AbdAMNAG (ORCPT <rfc822;w@1wt.eu>);
        Fri, 13 Jan 2017 08:00:06 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:49520 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751744AbdAMNAE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Jan 2017 08:00:04 -0500
Date: Fri, 13 Jan 2017 14:00:18 +0100
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Tomas Winkler <tomas.winkler@intel.com>,
        Jan Niehusmann <jan@gondor.com>,
        Alexander Usyskin <alexander.usyskin@intel.com>,
        linux-kernel@vger.kernel.org, Yu C Chen <yu.c.chen@intel.com>,
        Tomi P Sarvela <tomi.p.sarvela@intel.com>,
        Thorsten Leemhuis <linux@leemhuis.info>,
        Daniel Blueman <daniel@quora.org>, Len Brown <len.brown@intel.com>
Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for
 SPT and newer
Message-ID: <20170113130018.GA896@kroah.com>
References: <1484090841-16483-1-git-send-email-tomas.winkler@intel.com>
 <20170110224956.GA2897@x61s.reliablesolutions.de>
 <5B8DA87D05A7694D9FA63FD143655C1B5437A09D@hasmsx108.ger.corp.intel.com>
 <aac5b255-e817-f92d-2f37-2ca7b52cd957@molgen.mpg.de>
 <5B8DA87D05A7694D9FA63FD143655C1B5437A315@hasmsx108.ger.corp.intel.com>
 <b1ecfd53-e856-ce10-d56e-4fea27095a8f@molgen.mpg.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <b1ecfd53-e856-ce10-d56e-4fea27095a8f@molgen.mpg.de>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel wrote:
> Dear Tomas,
> 
> 
> On 01/11/17 15:12, Winkler, Tomas wrote:
> 
> > > > On 01/11/17 10:24, Winkler, Tomas wrote:
> > > > > > 
> > > > > > On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler wrote:
> > > > > > > On older platforms the command should be just ignored by the
> > > > > > > firmware but some older platforms misbehave so it's safer to send
> > > > > > > the command only if required.
> > > > > > 
> > > > > > Thanks! This fixes suspend-to-ram for me (on a Thinkpad x201s).
> > > > > 
> > > > > What about Dell XPS13?
> > > > 
> > > > With Linus' master branch from today, and Greg's char-misc-linus
> > > > merged
> > > > (Merge: 807b93e995d1 546cf3ef9c92), the regression is still there.
> > > 
> > > Hmm, this should work on KBL....
> > > 
> > > > I am now building a Linux kernel image with the two commits touching
> > > > `bus- fixup.c` reverted.
> > > 
> > > Thanks for the effort.
> > > 
> > > > Do you want me to open a separate bug report for that, or continue
> > > > debugging in the existing report [1], which is currently marked as resolved?
> > > 
> > > Let's get some more data, shouldn't take long time.
> > > > 
> > > > Do you have Kaby Lake devices sitting around for testing?
> > > 
> > > We will of course try to reproduce the issue locally.
> > 
> > Paul, currently we cannot reproduce this issue on Kaby Lake platforms on our side,
> 
> It looks like it’s a different issue. Reverting the two commits touching
> `bus-fixup.c`, did not help.
> 
> > we would be great for more debug data from your side.
> > You can get more info by enabling  mode debug logs
> > 
> > echo -n 'module mei +lfp' > /sys/kernel/debug/dynamic_debug/control
> > echo -n 'module mei_me +lfp' > /sys/kernel/debug/dynamic_debug/control
> 
> I am currently bisecting to find the culprit. 13 steps will take some time
> though.

I can duplicate this on my laptop here as well :(

Did you get anywhere with your bisection?

thanks,

greg k-h