From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751908AbdAMNTb (ORCPT ); Fri, 13 Jan 2017 08:19:31 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35958 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751806AbdAMNT0 (ORCPT ); Fri, 13 Jan 2017 08:19:26 -0500 Date: Fri, 13 Jan 2017 13:23:15 +0000 From: Lee Jones To: Enric Balletbo i Serra Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com, Olof Johansson , Alessandro Zummo , Alexandre Belloni , Stephen Barber Subject: Re: [PATCH 2/4] mfd: cros_ec: Introduce RTC commands and events definitions. Message-ID: <20170113132315.GC6864@dell> References: <20170111165221.17337-1-enric.balletbo@collabora.com> <20170111165221.17337-2-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170111165221.17337-2-enric.balletbo@collabora.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Jan 2017, Enric Balletbo i Serra wrote: > From: Stephen Barber > > The EC can function as a simple RT, this patch adds the RTC related > definitions needed by the rtc-cros-ec driver. > > Signed-off-by: Stephen Barber > Signed-off-by: Enric Balletbo i Serra > --- > include/linux/mfd/cros_ec_commands.h | 8 ++++++++ > 1 file changed, 8 insertions(+) Acked-by: Lee Jones > diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h > index 80d401d..73f7a62 100644 > --- a/include/linux/mfd/cros_ec_commands.h > +++ b/include/linux/mfd/cros_ec_commands.h > @@ -286,6 +286,9 @@ enum host_event_code { > /* Hang detect logic detected a hang and warm rebooted the AP */ > EC_HOST_EVENT_HANG_REBOOT = 21, > > + /* EC RTC event occurred */ > + EC_HOST_EVENT_RTC = 26, > + > /* > * The high bit of the event mask is not used as a host event code. If > * it reads back as set, then the entire event mask should be > @@ -790,6 +793,8 @@ enum ec_feature_code { > EC_FEATURE_USB_MUX = 23, > /* Motion Sensor code has an internal software FIFO */ > EC_FEATURE_MOTION_SENSE_FIFO = 24, > + /* EC has RTC feature that can be controlled by host commands */ > + EC_FEATURE_RTC = 27, > }; > > #define EC_FEATURE_MASK_0(event_code) (1UL << (event_code % 32)) > @@ -1682,6 +1687,9 @@ struct ec_response_rtc { > #define EC_CMD_RTC_SET_VALUE 0x46 > #define EC_CMD_RTC_SET_ALARM 0x47 > > +/* Pass as param to SET_ALARM to clear the current alarm */ > +#define EC_RTC_ALARM_CLEAR 0 > + > /*****************************************************************************/ > /* Port80 log access */ > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog