From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752177AbdAMPVm (ORCPT <rfc822;w@1wt.eu>);
        Fri, 13 Jan 2017 10:21:42 -0500
Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.163]:29508 "EHLO
        mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751678AbdAMPVj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 13 Jan 2017 10:21:39 -0500
X-RZG-AUTH: :P2EQZWCpfu+qG7CngxMFH1J+yackYocTD1iAi8x+OWi/zfN1cLnAYQz4mTFeMvQq5dKINYyAT3vOjfuqJMLHNFTTAImA3A==
X-RZG-CLASS-ID: mo00
Date: Fri, 13 Jan 2017 16:21:26 +0100
From: Olaf Hering <olaf@aepfle.de>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, devel@linuxdriverproject.org,
        linux-kernel@vger.kernel.org, Haiyang Zhang <haiyangz@microsoft.com>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        John Stultz <john.stultz@linaro.org>, Alex Ng <alexng@microsoft.com>,
        Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH RFC] hv_utils: implement Hyper-V PTP source
Message-ID: <20170113152126.GA31625@aepfle.de>
References: <alpine.DEB.2.20.1701101533260.3401@nanos>
 <20170113130543.7212-1-vkuznets@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="PEIAKu/WMn1b1Hv9"
Content-Disposition: inline
In-Reply-To: <20170113130543.7212-1-vkuznets@redhat.com>
User-Agent: Mutt/1.7.2 (6902)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--PEIAKu/WMn1b1Hv9
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

On Fri, Jan 13, Vitaly Kuznetsov wrote:

> +	hv_ptp_clock = ptp_clock_register(&ptp_hyperv_info, NULL);
> +	if (IS_ERR(hv_ptp_clock)) {

Should that be IS_ERR_OR_NULL to catch "!IS_REACHABLE(CONFIG_PTP_1588_CLOCK)"?

Olaf

--PEIAKu/WMn1b1Hv9
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCWHjwcgAKCRBdQqD6ppg2
ftCNAKDDTbF+IBH2QnsRl7dxdJiJQtUVggCgo+L3vj2KG3cD9sq4rEPUABpZ7gA=
=pKKA
-----END PGP SIGNATURE-----

--PEIAKu/WMn1b1Hv9--