From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752108AbdAMPfZ (ORCPT ); Fri, 13 Jan 2017 10:35:25 -0500 Received: from mout.kundenserver.de ([212.227.126.135]:64050 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751771AbdAMPfV (ORCPT ); Fri, 13 Jan 2017 10:35:21 -0500 From: Arnd Bergmann To: Alexandre Belloni Cc: Arnd Bergmann , Mark Brown , Alessandro Zummo , Maxime Coquelin , Alexandre Torgue , Amelie Delaunay , Mathieu Poirier , rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] rtc: stm32: use 32-bit cast for BIT() macro Date: Fri, 13 Jan 2017 16:32:53 +0100 Message-Id: <20170113153311.2611510-3-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20170113153311.2611510-1-arnd@arndb.de> References: <20170113153311.2611510-1-arnd@arndb.de> X-Provags-ID: V03:K0:aleEdqv3SEtMuXAMEwQ1IBVk7yCuukY0q1O/X/GxnPBm4/5IdSY +QdSo9cQX+g34qdVIvfJQ4aISI9KZXusIOLLrtCyniYPZrZ42MafSk+X/oyFh7cr5maWHLq uv+JXu+EtZ55xNTD5x9Yj6kSSa/Hf6aBTsZ14M0VW8R7/vaNZUQSULTKDjHxAvw+J1DhGkx QbJuGV+lihmR1reN5DxtA== X-UI-Out-Filterresults: notjunk:1;V01:K0:p/uXWyXC3S0=:T4pwVwhUbiPgUieSNr4KlG zYs1SNvZaI7/nnU5oiGYlUOGkokrGPelXEcdJbe/ZtjfDyPdKh5N4bQn8VFci8jVGrOJn1Hof FwZVQbv+IquXcUXXCMXske/ePSWjX/f2NxfL0T7mb42SnKqpuDHoQk3Ctg/Da/qUl7b0NM0ji dKn9cWbx31FLCFsGcS96cWn7vugn5CcL7aDbQjqUL2S9/KFUs70ZOjPr6FlBR6FsLDVdxWY/6 fiFxXF1IvuYim5oTm3qB8IkC0m5gxl7aoduby/FUCuGwhCQaaJfgU7GKMuxLwHYSBwGpMzHr2 xel4lmKFgtIu4JoDGAn2slmgJbrytUcQWNvjRu6WgneybXRvPdagVOU4HvoHNua4jLNpllm+c Dkvu7u173A0+xZMZLUGQPxyzXaAYDrWyxHqxxRaZKB3B5owLiADnLLY+FyGR6pMoe3bmIn5iT XU5uY6G8QfkXJbMBzn15DMwcAMPBbtAqroItvmuJ1o/0ZzxnE83QrphqCFl3AD63niCU6+Qn9 btFzF0UYvyOWpQkIOkb6hug8cqHYGl8NTVz4AUOsLEGik4tHao9TOzmk9x5c5wxONbmpMqN/o 6U0ty8ScZ4K8m4+RekcgYuC1talHQnzZa8BC9Kj2hzpMX6LOC+gCN9sc0mqI7u2sz5DO82Wrm 3Y9h2pL9UXBXYldny3BVBTHVo/jlhtgGORPVZosnbD2wZKU8ayU5upfu5kFsnnSmTDK4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using the ~ operator on a BIT() constant results in a large 'unsigned long' constant that won't fit into an 'unsigned int' function argument on 64-bit architectures, resulting in a harmless build warning in x86 allmodconfig: drivers/rtc/rtc-stm32.c: In function 'stm32_rtc_probe': drivers/rtc/rtc-stm32.c:651:51: error: large integer implicitly truncated to unsigned type [-Werror=overflow] regmap_update_bits(rtc->dbp, PWR_CR, PWR_CR_DBP, ~PWR_CR_DBP); This works around the warning by adding an explict cast to 'u32', but that is unfortunately a bit ugly and I feel there should be a better way to do this, possibly with some changes to either the bitops.h header or the regmap API. Cc: Mark Brown Fixes: 4e64350f42e2 ("rtc: add STM32 RTC driver") Signed-off-by: Arnd Bergmann --- drivers/rtc/rtc-stm32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c index 8c599f52124c..05d3dc89e55f 100644 --- a/drivers/rtc/rtc-stm32.c +++ b/drivers/rtc/rtc-stm32.c @@ -92,7 +92,7 @@ /* STM32_PWR_CR */ #define PWR_CR 0x00 /* STM32_PWR_CR bit field */ -#define PWR_CR_DBP BIT(8) +#define PWR_CR_DBP (u32)BIT(8) struct stm32_rtc { struct rtc_device *rtc_dev; -- 2.9.0