public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Matthew Wilcox <mawilcox@linuxonhyperv.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Matthew Wilcox <mawilcox@microsoft.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] radix-tree: Fix private list warnings
Date: Sat, 14 Jan 2017 10:42:31 -0500	[thread overview]
Message-ID: <20170114154231.GA26139@cmpxchg.org> (raw)
In-Reply-To: <1484270903-24307-1-git-send-email-mawilcox@linuxonhyperv.com>

On Thu, Jan 12, 2017 at 05:28:23PM -0800, Matthew Wilcox wrote:
> From: Matthew Wilcox <mawilcox@microsoft.com>
> 
> The newly introduced warning in radix_tree_free_nodes() was testing the
> wrong variable; it should have been 'old' instead of 'node'.  Rather
> than replace that one instance, I noticed that we can simply put the
> WARN_ON_ONCE in radix_tree_node_free() and it will be just as effective.
> 
> Fixes: ea07b862ac8e ("mm: workingset: fix use-after-free in shadow node shrinker")
> Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>

Thanks for the fix in radix_tree_free_nodes(). But I intentionally
spread out the warnings to retain the line numbers. The inlining in
that code will obscure which tree operation ends up triggering.

  reply	other threads:[~2017-01-14 16:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13  1:28 [PATCH] radix-tree: Fix private list warnings Matthew Wilcox
2017-01-14 15:42 ` Johannes Weiner [this message]
2017-01-14 21:31   ` Matthew Wilcox
2017-01-15  0:57     ` Johannes Weiner
2017-01-18 16:37       ` Johannes Weiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170114154231.GA26139@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mawilcox@linuxonhyperv.com \
    --cc=mawilcox@microsoft.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox