From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751378AbdANQAy (ORCPT ); Sat, 14 Jan 2017 11:00:54 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:37708 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbdANQAx (ORCPT ); Sat, 14 Jan 2017 11:00:53 -0500 Date: Sat, 14 Jan 2017 10:42:31 -0500 From: Johannes Weiner To: Matthew Wilcox Cc: Linus Torvalds , Matthew Wilcox , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] radix-tree: Fix private list warnings Message-ID: <20170114154231.GA26139@cmpxchg.org> References: <1484270903-24307-1-git-send-email-mawilcox@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484270903-24307-1-git-send-email-mawilcox@linuxonhyperv.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2017 at 05:28:23PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > The newly introduced warning in radix_tree_free_nodes() was testing the > wrong variable; it should have been 'old' instead of 'node'. Rather > than replace that one instance, I noticed that we can simply put the > WARN_ON_ONCE in radix_tree_node_free() and it will be just as effective. > > Fixes: ea07b862ac8e ("mm: workingset: fix use-after-free in shadow node shrinker") > Signed-off-by: Matthew Wilcox Thanks for the fix in radix_tree_free_nodes(). But I intentionally spread out the warnings to retain the line numbers. The inlining in that code will obscure which tree operation ends up triggering.