From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751887AbdANTRS (ORCPT ); Sat, 14 Jan 2017 14:17:18 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:36111 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751621AbdANTRQ (ORCPT ); Sat, 14 Jan 2017 14:17:16 -0500 Date: Sat, 14 Jan 2017 11:17:12 -0800 From: Dmitry Torokhov To: David Lechner Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Mark Rutland , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] Input: pwm-beeper: suppress error message on probe defer Message-ID: <20170114191712.GB31309@dtor-ws> References: <1484164921-30587-1-git-send-email-david@lechnology.com> <1484164921-30587-2-git-send-email-david@lechnology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1484164921-30587-2-git-send-email-david@lechnology.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 11, 2017 at 02:01:59PM -0600, David Lechner wrote: > This suppress printing an error message when pwm_get returns -EPROBE_DEFER. > Otherwise you get a bunch of noise in the kernel log. > > Signed-off-by: David Lechner > --- > drivers/input/misc/pwm-beeper.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c > index ce6eec4..30ac227 100644 > --- a/drivers/input/misc/pwm-beeper.c > +++ b/drivers/input/misc/pwm-beeper.c > @@ -104,9 +104,10 @@ static int pwm_beeper_probe(struct platform_device *pdev) > return -ENOMEM; > > beeper->pwm = devm_pwm_get(dev, NULL); > - if (IS_ERR(beeper->pwm)) { > - error = PTR_ERR(beeper->pwm); > - dev_err(dev, "Failed to request pwm device: %d\n", error); > + error = PTR_ERR_OR_ZERO(beeper->pwm); > + if (error) { I do not find it in any way clearer than if (IS_ERR()) { ... I prefer PTR_ERR_OR_ZERO be used when you need to return value without acting on it. I can adjust locally, no need to resubmit. > + if (error != -EPROBE_DEFER) > + dev_err(dev, "Failed to request pwm device\n"); > return error; > } > > -- > 2.7.4 > -- Dmitry