From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750848AbdAOGyq (ORCPT ); Sun, 15 Jan 2017 01:54:46 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33764 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729AbdAOGyo (ORCPT ); Sun, 15 Jan 2017 01:54:44 -0500 Date: Sun, 15 Jan 2017 07:54:40 +0100 From: Ingo Molnar To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, dvhart@linux.intel.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com Subject: Re: [PATCH tip/core/rcu 2/3] srcu: Force full grace-period ordering Message-ID: <20170115065440.GA26581@gmail.com> References: <20170114091941.GA22961@linux.vnet.ibm.com> <1484385601-23379-2-git-send-email-paulmck@linux.vnet.ibm.com> <20170114093550.GB14970@gmail.com> <20170114195417.GW5238@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170114195417.GW5238@linux.vnet.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Paul E. McKenney wrote: > > > + */ > > > +#ifdef CONFIG_PPC > > > +#define smp_mb__after_unlock_lock() smp_mb() /* Full ordering for lock. */ > > > +#else /* #ifdef CONFIG_PPC */ > > > +#define smp_mb__after_unlock_lock() do { } while (0) > > > +#endif /* #else #ifdef CONFIG_PPC */ > > > > Yeah, so I realize that this was pre-existing code, but putting CONFIG_$ARCH > > #ifdefs into generic headers is generally frowned upon. > > > > The canonical approach would be either to define a helper Kconfig variable that > > can be set by PPC (but other architectures don't need to set it), or to expose a > > suitable macro (function) for architectures to define in their barrier.h arch > > header file. > > Very well, I will add a separate commit for this. 4.11 OK? Sure! Thanks, Ingo