From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751118AbdAOK5J (ORCPT ); Sun, 15 Jan 2017 05:57:09 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:54760 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbdAOK5I (ORCPT ); Sun, 15 Jan 2017 05:57:08 -0500 Date: Sun, 15 Jan 2017 11:57:21 +0100 From: Greg KH To: Kartikey Singh Cc: insafonov@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: staging: rtl8188eu: include: Removed unnecssary defined macros Message-ID: <20170115105721.GC26374@kroah.com> References: <20170115073923.wqtzyolvv44rnqzg@kartikey-HP-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170115073923.wqtzyolvv44rnqzg@kartikey-HP-Notebook> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 15, 2017 at 01:09:23PM +0530, Kartikey Singh wrote: > Removed macros not in use. > > Signed-off-by: Kartikey Singh > --- > drivers/staging/rtl8188eu/include/wifi.h | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/include/wifi.h b/drivers/staging/rtl8188eu/include/wifi.h > index 9e08e68..9c9c334 100644 > --- a/drivers/staging/rtl8188eu/include/wifi.h > +++ b/drivers/staging/rtl8188eu/include/wifi.h > @@ -480,15 +480,6 @@ static inline int IsFrameTypeCtrl(unsigned char *pframe) > Below is the definition for 802.11n > ------------------------------------------------------------------------------*/ > > -#define SetOrderBit(pbuf) \ > - do { \ > - *(unsigned short *)(pbuf) |= cpu_to_le16(_ORDER_); \ > - } while (0) > - > -#define GetOrderBit(pbuf) \ > - (((*(unsigned short *)(pbuf)) & le16_to_cpu(_ORDER_)) != 0) > - > - That's good, but: > /** > * struct rtw_ieee80211_bar - HT Block Ack Request > * > @@ -758,6 +749,8 @@ enum ht_cap_ampdu_factor { > #define P2P_STATUS_FAIL_USER_REJECT 0x0B > > /* Value of Invitation Flags Attribute */ > + > +/* > #define P2P_INVITATION_FLAGS_PERSISTENT BIT(0) > > #define DMP_P2P_DEVCAP_SUPPORT (P2P_DEVCAP_SERVICE_DISCOVERY | \ > @@ -766,6 +759,7 @@ enum ht_cap_ampdu_factor { > P2P_DEVCAP_INVITATION_PROC) > > #define DMP_P2P_GRPCAP_SUPPORT (P2P_GRPCAP_INTRABSS) > +*/ Why did you comment these out and not just remove them? No need keeping around useless stuff, right? thanks, greg k-h