From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751332AbdAOXjg (ORCPT ); Sun, 15 Jan 2017 18:39:36 -0500 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35361 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbdAOXje (ORCPT ); Sun, 15 Jan 2017 18:39:34 -0500 Date: Sun, 15 Jan 2017 15:39:30 -0800 From: Dmitry Torokhov To: Arnd Bergmann Cc: Christopher Heiny , Nick Dyer , Linux Kernel Mailing List , linux-input@vger.kernel.org, Andrew Duggan Subject: Re: [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol Message-ID: <20170115233930.GG23285@dtor-ws> References: <20170110121718.2992211-1-arnd@arndb.de> <20170113062203.GD22630@dtor-ws> <3051252.9A92ba0o10@wuerfel> <20170113214240.GA4246@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 14, 2017 at 01:09:57PM +0100, Arnd Bergmann wrote: > On Jan 13, 2017 10:42 PM, "Dmitry Torokhov" wrote: > > On Fri, Jan 13, 2017 at 10:34:32PM +0100, Arnd Bergmann wrote: > > > config RMI4_F03_SERIO > > > tristate > > > depends on RMI4_CORE > > > depends on RMI4_F03 > > > default RMI4_CORE > > > select SERIO > > > > > > As that avoids the 'depends on SERIO=y || RMI4_CORE=SERIO' statement that > > > is different from the other SERIO users, it keeps it all in one place, > > > and it doesn't > > > prevent you from seeing the RMI4_F03 symbol when SERIO=m. > > Hmm, if this works and resilient with user changing symbols after > > they've been auto-selected then I like it. How can we run it through > > multitude of randconfigs? > > I've successfully run it over night on a few hundred randconfig builds without > problems now, so I'm pretty confident it works. > > The hidden option will ensure the configuration is always valid even when > the user changes it, the only thing that can be unexpected is the same as > every 'select': when you enable this option, SERIO will get turned on, and > when you disable it again after leaving 'menuconfig', it stays on. Great. Could you please send me real patch and I'll get it to Linus? Thanks. -- Dmitry