public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@stgolabs.net>
To: mingo@kernel.org, peterz@infradead.org, oleg@redhat.com
Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH 1/2] sched: Introduce rcuwait machinery
Date: Sun, 15 Jan 2017 17:32:32 -0800	[thread overview]
Message-ID: <20170116013232.GA7295@linux-80c1.suse> (raw)
In-Reply-To: <1482426096-12792-2-git-send-email-dave@stgolabs.net>

On Thu, 22 Dec 2016, Bueso wrote:

>+	WARN_ON(current->exit_state);                                   \

While not related to this patch, but per 3245d6acab9 (exit: fix race
between wait_consider_task() and wait_task_zombie()), should we not
*_ONCE() all things ->exit_state? I'm not really refering to a specific
bug (much less here, where that race would not matter obviously), but
if nothing else, for documentation -- and I doubt it would make any
difference performance wise.

Thanks,
Davidlohr

  parent reply	other threads:[~2017-01-16  1:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-22 17:01 [PATCH 0/2] sched: Introduce rcuwait Davidlohr Bueso
2016-12-22 17:01 ` [PATCH 1/2] sched: Introduce rcuwait machinery Davidlohr Bueso
2016-12-22 19:27   ` kbuild test robot
2017-01-03 23:20     ` Davidlohr Bueso
2016-12-22 19:55   ` kbuild test robot
2017-01-16  1:32   ` Davidlohr Bueso [this message]
2017-01-17 17:41     ` Oleg Nesterov
2016-12-22 17:01 ` [PATCH 2/2] locking/percpu-rwsem: Replace waitqueue with rcuwait Davidlohr Bueso
2017-01-09 18:26 ` [PATCH 0/2] sched: Introduce rcuwait Davidlohr Bueso
2017-01-10 18:35   ` Oleg Nesterov
2017-01-10 19:37     ` Davidlohr Bueso
  -- strict thread matches above, loose matches on Subject: below --
2017-01-11 15:22 [PATCH v2 " Davidlohr Bueso
2017-01-11 15:22 ` [PATCH 1/2] sched: Introduce rcuwait machinery Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170116013232.GA7295@linux-80c1.suse \
    --to=dave@stgolabs.net \
    --cc=dbueso@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox