From: Dave Young <dyoung@redhat.com>
To: Matt Fleming <matt@codeblueprint.co.uk>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
dyoung@redhat.com, x86@kernel.org,
Nicolai Stange <nicstange@gmail.com>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
hpa@zytor.com, Dan Williams <dan.j.williams@intel.com>,
mika.penttila@nextfour.com, bhsharma@redhat.com
Subject: [PATCH V2 4/4] efi/x86: make efi_memmap_reserve only insert into boot mem areas
Date: Mon, 16 Jan 2017 10:45:58 +0800 [thread overview]
Message-ID: <20170116025026.586405871@redhat.com> (raw)
In-Reply-To: 20170116024554.461236678@redhat.com
[-- Attachment #1: efi-memmap-insert-only-handle-boot-ranges.patch --]
[-- Type: text/plain, Size: 2671 bytes --]
efi_mem_reserve cares only about boot services regions, for making sure
later efi_free_boot_services does not free areas which are still useful,
such as bgrt image buffer.
So add a new argument to efi_memmap_insert for this purpose.
Signed-off-by: Dave Young <dyoung@redhat.com>
---
v1->v2: only check EFI_BOOT_SERVICES_CODE/_DATA
arch/x86/platform/efi/quirks.c | 2 +-
drivers/firmware/efi/fake_mem.c | 3 ++-
drivers/firmware/efi/memmap.c | 6 +++++-
include/linux/efi.h | 4 ++--
4 files changed, 10 insertions(+), 5 deletions(-)
--- linux-x86.orig/drivers/firmware/efi/memmap.c
+++ linux-x86/drivers/firmware/efi/memmap.c
@@ -229,7 +229,7 @@ int __init efi_memmap_split_count(efi_me
* to see how large @buf needs to be.
*/
void __init efi_memmap_insert(struct efi_memory_map *old_memmap, void *buf,
- struct efi_mem_range *mem)
+ struct efi_mem_range *mem, bool boot_only)
{
u64 m_start, m_end, m_attr;
efi_memory_desc_t *md;
@@ -262,6 +262,10 @@ void __init efi_memmap_insert(struct efi
start = md->phys_addr;
end = md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT) - 1;
+ if (boot_only && !(md->type == EFI_BOOT_SERVICES_CODE ||
+ md->type == EFI_BOOT_SERVICES_DATA))
+ continue;
+
if (m_start <= start && end <= m_end)
md->attribute |= m_attr;
--- linux-x86.orig/arch/x86/platform/efi/quirks.c
+++ linux-x86/arch/x86/platform/efi/quirks.c
@@ -226,7 +226,7 @@ void __init efi_arch_mem_reserve(phys_ad
return;
}
- efi_memmap_insert(&efi.memmap, new, &mr);
+ efi_memmap_insert(&efi.memmap, new, &mr, true);
early_memunmap(new, new_size);
efi_memmap_install(new_phys, num_entries);
--- linux-x86.orig/drivers/firmware/efi/fake_mem.c
+++ linux-x86/drivers/firmware/efi/fake_mem.c
@@ -85,7 +85,8 @@ void __init efi_fake_memmap(void)
}
for (i = 0; i < nr_fake_mem; i++)
- efi_memmap_insert(&efi.memmap, new_memmap, &fake_mems[i]);
+ efi_memmap_insert(&efi.memmap, new_memmap, &fake_mems[i],
+ false);
/* swap into new EFI memmap */
early_memunmap(new_memmap, efi.memmap.desc_size * new_nr_map);
--- linux-x86.orig/include/linux/efi.h
+++ linux-x86/include/linux/efi.h
@@ -959,8 +959,8 @@ extern int __init efi_memmap_install(phy
extern int __init efi_memmap_split_count(efi_memory_desc_t *md,
struct range *range);
extern void __init efi_memmap_insert(struct efi_memory_map *old_memmap,
- void *buf, struct efi_mem_range *mem);
-
+ void *buf, struct efi_mem_range *mem,
+ bool boot_only);
extern int efi_config_init(efi_config_table_type_t *arch_tables);
#ifdef CONFIG_EFI_ESRT
extern void __init efi_esrt_init(void);
next prev parent reply other threads:[~2017-01-16 2:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 2:45 [PATCH V2 0/4] efi/x86: move efi bgrt init code to early init Dave Young
2017-01-16 2:45 ` [PATCH V2 1/4] efi/x86: move efi bgrt init code to early init code Dave Young
2017-01-17 10:39 ` Nicolai Stange
2017-01-17 17:10 ` Ard Biesheuvel
2017-01-18 2:16 ` Dave Young
2017-01-18 13:48 ` [PATCH V3 " Dave Young
2017-01-18 14:00 ` Ard Biesheuvel
2017-01-18 19:24 ` Bhupesh Sharma
2017-01-19 12:48 ` Ard Biesheuvel
2017-01-26 3:39 ` Dave Young
2017-01-16 2:45 ` [PATCH V2 2/4] efi/x86: move efi_print_memmap to drivers/firmware/efi/memmap.c Dave Young
2017-01-17 10:39 ` Nicolai Stange
2017-01-17 17:11 ` Ard Biesheuvel
2017-01-16 2:45 ` [PATCH V2 3/4] efi/x86: add debug code to print cooked memmap Dave Young
2017-01-17 10:39 ` Nicolai Stange
2017-01-16 2:45 ` Dave Young [this message]
2017-01-17 10:40 ` [PATCH V2 4/4] efi/x86: make efi_memmap_reserve only insert into boot mem areas Nicolai Stange
2017-01-17 17:13 ` Ard Biesheuvel
2017-01-17 19:48 ` Nicolai Stange
2017-01-18 11:01 ` Dave Young
2017-01-18 11:06 ` Dave Young
2017-01-18 13:33 ` Dave Young
2017-01-18 2:28 ` Dave Young
2017-01-27 17:03 ` [PATCH V2 0/4] efi/x86: move efi bgrt init code to early init Ard Biesheuvel
2017-02-03 7:12 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116025026.586405871@redhat.com \
--to=dyoung@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=bhsharma@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mika.penttila@nextfour.com \
--cc=mingo@kernel.org \
--cc=nicstange@gmail.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).