From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751028AbdAPE5L (ORCPT ); Sun, 15 Jan 2017 23:57:11 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49593 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750857AbdAPE5J (ORCPT ); Sun, 15 Jan 2017 23:57:09 -0500 Date: Sun, 15 Jan 2017 20:56:22 -0800 From: "Paul E. McKenney" To: "Zheng, Lv" Cc: Borislav Petkov , "Rafael J. Wysocki" , Linux Kernel Mailing List , "stan.kain@gmail.com" , "waffolz@hotmail.com" , Josh Triplett , Steven Rostedt , "mathieu.desnoyers@efficios.com" , "jiangshanlai@gmail.com" , Ingo Molnar , Linus Torvalds Subject: Re: [PATCH] rcu: Narrow early boot window of illegal synchronous grace periods Reply-To: paulmck@linux.vnet.ibm.com References: <20170113023807.GA27120@linux.vnet.ibm.com> <20170113112519.q6tmariemhhk5e56@pd.tnic> <20170114080022.GS5238@linux.vnet.ibm.com> <20170114103525.i5bob5tjszqdfpvn@pd.tnic> <20170114125017.5wp2khn5scezeuau@pd.tnic> <1AE640813FDE7649BE1B193DEA596E886CE2BD4E@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1AE640813FDE7649BE1B193DEA596E886CE2BD4E@SHSMSX101.ccr.corp.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17011604-0020-0000-0000-00000B159437 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006441; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000199; SDB=6.00808202; UDB=6.00393583; IPR=6.00585561; BA=6.00005056; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013928; XFM=3.00000011; UTC=2017-01-16 04:57:06 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17011604-0021-0000-0000-0000593C9B42 Message-Id: <20170116045622.GK5238@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-16_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701160078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2017 at 01:57:25AM +0000, Zheng, Lv wrote: > Hi, > > > From: Borislav Petkov [mailto:bp@alien8.de] > > Subject: Re: [PATCH] rcu: Narrow early boot window of illegal synchronous grace periods > > > > On Sat, Jan 14, 2017 at 01:27:40PM +0100, Rafael J. Wysocki wrote: > > > OK, so this fixes the problem with synchronize_rcu_expedited() in > > > acpi_os_map_cleanup(), right? > > > > Yeah. > > > > > I wonder if the ACPI-specific fix is still needed, then? > > > > It is not strictly necessary. If you still think it would be better to > > have it regardless, you could pick it up. I.e., making ACPI more robust, > > yadda yadda. > > > > I dunno, though, perhaps it is only complicating the code unnecessarily > > and then can be safely ignored with a mental note for future freezes. > > Glad to see it fixed inside of the API provider. > > IMO, ACPI fix is unnecessary as ACPI is just a user of the RCU APIs. > And it's pointless to add special checks in the user side in order to use one of them. With some luck, the RCU patch will go in sooner rather than later. Should it be delayed for whatever reason, the ACPI patch might well be needed in the meantime. Thanx, Paul