From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751193AbdAPJiu (ORCPT ); Mon, 16 Jan 2017 04:38:50 -0500 Received: from mx2.suse.de ([195.135.220.15]:51990 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbdAPJit (ORCPT ); Mon, 16 Jan 2017 04:38:49 -0500 Date: Mon, 16 Jan 2017 10:38:47 +0100 From: Michal Hocko To: Borislav Petkov Cc: Vlastimil Babka , Linux MM , LKML , Andrew Morton Subject: Re: [PATCH] mm/slub: Add a dump_stack() to the unexpected GFP check Message-ID: <20170116093846.GD13641@dhcp22.suse.cz> References: <20170116091643.15260-1-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170116091643.15260-1-bp@alien8.de> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Let's add Andrew] On Mon 16-01-17 10:16:43, Borislav Petkov wrote: > From: Borislav Petkov > > We wanna know who's doing such a thing. Like slab.c does that. Yes this was an omission on my side in 72baeef0c271 ("slab: do not panic on invalid gfp_mask"). > > Signed-off-by: Borislav Petkov Acked-by: Michal Hocko Thanks! > --- > mm/slub.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/slub.c b/mm/slub.c > index 067598a00849..1b0fa7625d6d 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1623,6 +1623,7 @@ static struct page *new_slab(struct kmem_cache *s, gfp_t flags, int node) > flags &= ~GFP_SLAB_BUG_MASK; > pr_warn("Unexpected gfp: %#x (%pGg). Fixing up to gfp: %#x (%pGg). Fix your code!\n", > invalid_mask, &invalid_mask, flags, &flags); > + dump_stack(); > } > > return allocate_slab(s, > -- > 2.11.0 -- Michal Hocko SUSE Labs