From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751107AbdAPJkS (ORCPT ); Mon, 16 Jan 2017 04:40:18 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:17355 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750826AbdAPJkP (ORCPT ); Mon, 16 Jan 2017 04:40:15 -0500 Date: Mon, 16 Jan 2017 12:39:54 +0300 From: Dan Carpenter To: David Miller Cc: peppe.cavallaro@st.com, Joao.Pinto@synopsys.com, alexandre.torgue@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch net-next] stmmac: indent an if statement Message-ID: <20170116093954.GB4104@mwanda> References: <20170112184631.GA12157@mwanda> <20170115.221438.1956356112755181222.davem@davemloft.net> <20170116091924.GA4104@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170116091924.GA4104@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2017 at 12:19:24PM +0300, Dan Carpenter wrote: > On Sun, Jan 15, 2017 at 10:14:38PM -0500, David Miller wrote: > > From: Dan Carpenter > > Date: Thu, 12 Jan 2017 21:46:32 +0300 > > > > > The break statement should be indented one more tab. > > > > > > Signed-off-by: Dan Carpenter > > > > Applied, but like Julia I think we might have a missing of_node_put() > > here. > > Of course, sorry for dropping the ball on this. I'll send a patch for > that. > Actually, I've looked at it some more and I think this function is OK. We're supposed to do an of_node_put() later... I can't find where that happens, but presumably that's because I don't know stmmac well. This code here, though, is fine. regards, dan carpenter