Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT and newer

Thorsten Leemhuis
2017-01-17T08:30:17Z

Greg Kroah-Hartman wrote on 16.01.2017 12:05:
> On Sun, Jan 15, 2017 at 11:58:30AM +0100, Greg Kroah-Hartman wrote:
>> On Sun, Jan 15, 2017 at 07:19:03AM +0000, Winkler, Tomas wrote:
>> > > Subject: Re: [char-misc for 4.10-rc4 V2] mei: bus: enable OS version only for SPT
>> > > and newer
>> > > On Sat, Jan 14, 2017 at 08:27:31PM +0100, Paul Menzel wrote:
>> > > > On 2017-01-13 14:00, Greg Kroah-Hartman wrote:
>> > > > > On Wed, Jan 11, 2017 at 03:26:06PM +0100, Paul Menzel wrote:
>> > > > > > On 01/11/17 15:12, Winkler, Tomas wrote:
>> > > > > > > > > On 01/11/17 10:24, Winkler, Tomas wrote:
>> > > > > > > > > > > On Wed, Jan 11, 2017 at 01:27:21AM +0200, Tomas Winkler
>> > > wrote:
>> > > > > > > > > > > > On older platforms the command should be just ignored
>> > > > > > > > > > > > by the firmware but some older platforms misbehave so
>> > > > > > > > > > > > it's safer to send the command only if required.
>> > > > > > > > > > > Thanks! This fixes suspend-to-ram for me (on a Thinkpad x201s).
>> > > > > > > > > > What about Dell XPS13?
>> > > > > > > > > With Linus' master branch from today, and Greg's
>> > > > > > > > > char-misc-linus merged
>> > > > > > > > > (Merge: 807b93e995d1 546cf3ef9c92), the regression is still there.
> […]
>> > > > > > I am currently bisecting to find the culprit. 13 steps will take
>> > > > > > some time though.
>> > > > > I can duplicate this on my laptop here as well :(
>> > > > Which system do you have?
>> > > A Dell XPS13, don't know what cpu type it is, here's the output of one cpu from
>> > > /proc/cpuinfo
> […]
>> > > model name : Intel(R) Core(TM) i7-6560U CPU @ 2.20GHz
>> > > > > Did you get anywhere with your bisection?
>> > > > Sorry, I replied to a different message with my status.
> > > You are close! I'll try bisection tomorrow if I have some spare time.

Paul, did you get any closer? I have trouble finding time for a proper
bisection (it's a bit chaotic here right now :-/ )

>> > Greg, is that same Laptop mode as Paul's, you've experience the issue on?
>> It's the same model name, but as this model has been shipped with many
>> different CPU versions over the years, I'm not sure if it is the exact
>> same one.

Gregs afaics is Skylake generation (XPS 13 (9350)), Paul and I have a
Kaby Lake (XPS 13 (9360)), which is one generation newer (Wifi is also
different; other components likely as well).

> Ok, 4.10-rc4 seems to have fixed this issue with me. I don't know what
> it was, but I can't duplicate it anymore.

Good to hear.

> Paul, are you still having this issue?

Don't know about Paul, but I did a quick test with rc4 on my machine and
the issue is still there :-/

Ciao, Thorsten