* [PATCH v2] USB: cypress_m8: remove unused variable
@ 2017-01-03 21:01 Sudip Mukherjee
2017-01-16 11:27 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Sudip Mukherjee @ 2017-01-03 21:01 UTC (permalink / raw)
To: Johan Hovold, Greg Kroah-Hartman; +Cc: linux-kernel, linux-usb, Sudip Mukherjee
From: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
The variable havedata was only being set but never used afterwards.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---
v2: changed the from line
drivers/usb/serial/cypress_m8.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
index bbeeb2b..90110de 100644
--- a/drivers/usb/serial/cypress_m8.c
+++ b/drivers/usb/serial/cypress_m8.c
@@ -1069,7 +1069,6 @@ static void cypress_read_int_callback(struct urb *urb)
unsigned char *data = urb->transfer_buffer;
unsigned long flags;
char tty_flag = TTY_NORMAL;
- int havedata = 0;
int bytes = 0;
int result;
int i = 0;
@@ -1118,16 +1117,12 @@ static void cypress_read_int_callback(struct urb *urb)
priv->current_status = data[0] & 0xF8;
bytes = data[1] + 2;
i = 2;
- if (bytes > 2)
- havedata = 1;
break;
case packet_format_2:
/* This is for the CY7C63743... */
priv->current_status = data[0] & 0xF8;
bytes = (data[0] & 0x07) + 1;
i = 1;
- if (bytes > 1)
- havedata = 1;
break;
}
spin_unlock_irqrestore(&priv->lock, flags);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] USB: cypress_m8: remove unused variable
2017-01-03 21:01 [PATCH v2] USB: cypress_m8: remove unused variable Sudip Mukherjee
@ 2017-01-16 11:27 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2017-01-16 11:27 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Johan Hovold, Greg Kroah-Hartman, linux-kernel, linux-usb,
Sudip Mukherjee
On Tue, Jan 03, 2017 at 09:01:10PM +0000, Sudip Mukherjee wrote:
> From: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>
> The variable havedata was only being set but never used afterwards.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> ---
>
> v2: changed the from line
Now applied, thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-16 11:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-03 21:01 [PATCH v2] USB: cypress_m8: remove unused variable Sudip Mukherjee
2017-01-16 11:27 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox