From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751727AbdAPNbO (ORCPT ); Mon, 16 Jan 2017 08:31:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43070 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751559AbdAPNao (ORCPT ); Mon, 16 Jan 2017 08:30:44 -0500 Date: Mon, 16 Jan 2017 15:30:42 +0200 From: "Michael S. Tsirkin" To: Amit Shah Cc: "G. Campana" , virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] virtio_console: fix a crash in config_work_handler Message-ID: <20170116153032-mutt-send-email-mst@kernel.org> References: <20170116033550.GK16209@amit-lp.rh> <1484559902-5346-1-git-send-email-gcampana@quarkslab.com> <20170116102723.GM16209@amit-lp.rh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170116102723.GM16209@amit-lp.rh> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 16 Jan 2017 13:30:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2017 at 03:57:23PM +0530, Amit Shah wrote: > On (Mon) 16 Jan 2017 [10:45:02], G. Campana wrote: > > Using control_work instead of config_work as the 3rd argument to > > container_of results in an invalid portdev pointer. Indeed, the work > > structure is initialized as below: > > > > INIT_WORK(&portdev->config_work, &config_work_handler); > > > > It leads to a crash when portdev->vdev is dereferenced later. This bug > > is triggered when the guest uses a virtio-console without multiport > > feature and receives a config_changed virtio interrupt. > > > > Signed-off-by: G. Campana > > Reviewed-by: Amit Shah > > Michael, can you please pick this up? > > Amit Sure.