From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751108AbdAPRYv (ORCPT ); Mon, 16 Jan 2017 12:24:51 -0500 Received: from mga07.intel.com ([134.134.136.100]:25021 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbdAPRYs (ORCPT ); Mon, 16 Jan 2017 12:24:48 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,240,1477983600"; d="scan'208";a="53905606" Date: Mon, 16 Jan 2017 19:24:43 +0200 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: tpmdd-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, James Bottomley , Peter Huewe , Marcel Selhorst , open list Subject: Re: [PATCH RFC v3 5/5] tpm2: expose resource manager via a device link /dev/tpms Message-ID: <20170116172443.kaakeyahnril55r3@intel.com> References: <20170116131215.28930-1-jarkko.sakkinen@linux.intel.com> <20170116131215.28930-6-jarkko.sakkinen@linux.intel.com> <20170116161413.GA19979@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170116161413.GA19979@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2017 at 09:14:13AM -0700, Jason Gunthorpe wrote: > On Mon, Jan 16, 2017 at 03:12:11PM +0200, Jarkko Sakkinen wrote: > > > @@ -199,7 +227,9 @@ struct tpm_chip *tpm_chip_alloc(struct device *pdev, > > return chip; > > > > out: > > + put_device(&chip->devrm); > > put_device(&chip->dev); > > + put_device(&chip->devrm); > > return ERR_PTR(rc); > > } > > Something has gone wrong here.. Not a big surprise. There were a bunch of these small patches that I had to squash. Thanks for spotting this. Funny that I didn't experiece any issues when I run my smoke tests. /Jarkko